Skip to content

Test detsys-ts update #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grahamc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test detsys-ts update #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@actions/core": "^3.0.0",
"@actions/exec": "^3.0.0",
"@actions/github": "^9.0.0",
"detsys-ts": "github:DeterminateSystems/detsys-ts",
"detsys-ts": "github:DeterminateSystems/detsys-ts#push-sqvzmxuokwlk",

@coderabbitai coderabbitai Bot Apr 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

REF="push-sqvzmxuokwlk"
API="https://api.github.com/repos/DeterminateSystems/detsys-ts/commits/${REF}"

echo "Resolving detsys-ts ref: ${REF}"
SHA="$(curl -fsSL "$API" | jq -r '.sha')"
echo "Resolved SHA: $SHA"

if [[ ! "$SHA" =~ ^[0-9a-f]{40}$ ]]; then
  echo "Ref did not resolve to a 40-char commit SHA."
  exit 1
fi

if [[ -f package-lock.json ]]; then
  echo "Found package-lock.json. Checking detsys-ts resolution entries:"
  jq -r '.. | .resolved? // empty' package-lock.json | rg -n 'detsys-ts|DeterminateSystems/detsys-ts' || true
else
  echo "No package-lock.json found in repository root."
fi

Repository: DeterminateSystems/nix-installer-action

Length of output: 348

🏁 Script executed:

cat -n package.json | sed -n '30,35p'

Repository: DeterminateSystems/nix-installer-action

Length of output: 337

Replace mutable ref with immutable commit SHA in detsys-ts dependency

Line 32 uses #push-sqvzmxuokwlk, a mutable branch/tag reference. While the lockfile pins the resolved immutable commit, using an immutable SHA directly in package.json is clearer and prevents accidental re-resolution to a different commit if the ref moves. The ref currently resolves to ee36f3f49d08fa939d3ff3080226441dc5df366a.

Suggested change 
-    "detsys-ts": "github:DeterminateSystems/detsys-ts#push-sqvzmxuokwlk",
+    "detsys-ts": "github:DeterminateSystems/detsys-ts#ee36f3f49d08fa939d3ff3080226441dc5df366a",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"detsys-ts": "github:DeterminateSystems/detsys-ts#push-sqvzmxuokwlk",
"detsys-ts": "github:DeterminateSystems/detsys-ts#ee36f3f49d08fa939d3ff3080226441dc5df366a",
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 32, The detsys-ts dependency in package.json currently
uses a mutable ref "github:DeterminateSystems/detsys-ts#push-sqvzmxuokwlk";
replace that ref with the immutable commit SHA so the dependency cannot
move—update the detsys-ts entry to
"github:DeterminateSystems/detsys-ts#ee36f3f49d08fa939d3ff3080226441dc5df366a"
(use the provided SHA ee36f3f49d08fa939d3ff3080226441dc5df366a) and save
package.json, then run your package manager install to ensure lockfile
consistency.

"got": "^14.6.6",
"string-argv": "^0.3.2",
"vitest": "^3.2.4"
Expand Down
Loading