Try using the new experimental app-sdk and app-sdk-react#60
Open
HappyPaul55 wants to merge 4 commits intomainfrom
Open
Try using the new experimental app-sdk and app-sdk-react#60HappyPaul55 wants to merge 4 commits intomainfrom
HappyPaul55 wants to merge 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR transitions the project from a pnpm‑based Node.js environment to a Deno‑based one, aiming for smaller bundle sizes and quicker load times.
- Transition to Deno with new configuration files (deno.json, updated DevContainer, VS Code settings)
- Removal of legacy Jest, Babel, and associated configurations
- Updates to workflows and documentation to reflect the new environment
Reviewed Changes
Copilot reviewed 46 out of 46 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| jest.setup.ts | Removed Jest-related setup as part of the Deno transition |
| deno.json | Introduces Deno configuration and tasks |
| custom-jest-resolver.js | Removed legacy Jest resolver functionality |
| config/jest/* | Removed Jest configuration files |
| SETUP.md | Updated formatting for clarity |
| README.md | Updated documentation; however, some commands still reference pnpm |
| LICENSE.md | Updated copyright year |
| DESCRIPTION.md | Minor formatting updates |
| .vscode/tasks.json | Replaced pnpm commands with Deno tasks |
| .vscode/launch.json | Updated runtime executable to use Deno |
| .npmrc | Removed obsolete configuration |
| .github/workflows/subworkflow-build.yml | Updated workflow commands to use Deno and removed Sentry-related vars |
| .eslintrc.js & .eslintignore | Removed legacy ESLint configurations |
| .devcontainer/devcontainer.json | Updated to install Deno and use the correct pnpmVersion field |
| .babelrc.json | Removed legacy Babel configurations |
Comments suppressed due to low confidence (1)
README.md:93
- The README still references pnpm commands for installing and starting the app; update these instructions to reflect the new Deno-based commands to avoid confusion.
pnpm start
|
Build for commit 4c0388b deployed to: https://iframe-pr-60.ci.next.deskprodemo.com URLs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major code change, but from a users point of view, this is minor - if anything, it's smaller bundle sizes and quicker load times.
This pull request introduces a major overhaul of the project, transitioning from a
pnpm-based Node.js setup to adeno-based environment. It includes the removal of legacy configurations, updates to workflows, and adjustments to development and build processes. Below is a summary of the most important changes:Transition to Deno
.devcontainer/devcontainer.jsonto replacepnpmwith Deno, including the installation of Deno viaonCreateCommandand replacing thepnpmVersionfield withpnpmVersion. Additionally, the ESLint extension was replaced with the Deno extension. [1] [2].vscode/launch.jsonand.vscode/tasks.jsonto replacepnpmcommands with equivalent Deno commands for building and testing. [1] [2] [3]Removal of Legacy Configurations
.babelrc.json,.eslintignore,.eslintrc.js, and.npmrc, as these are no longer relevant in the Deno-based environment. [1] [2] [3] [4]cssTransform.js,fileTransform.js,global-setup.js, andcustom-jest-resolver.js) from theconfig/jestdirectory, as the testing framework has been replaced. [1] [2] [3] [4]Workflow Updates
.github/workflows/subworkflow-build.ymlto replacepnpmlinting, testing, and building commands with Deno equivalents. Additionally, removed Sentry-related environment variables and commands.Documentation Updates
README.md,SETUP.md, andDESCRIPTION.mdto reflect the transition to Deno and improve formatting for readability. [1] [2] [3] [4] [5] [6]Miscellaneous
LICENSE.mdto reflect the copyright year change from 2024 to 2025.This transition simplifies the development environment and aligns the project with modern tooling, while removing outdated dependencies and configurations.