feature: add hebrew, arabic, hungarian text#141
Conversation
* This is a proof of a feature, not a change. It validates that GraphCompose can render Hebrew, Arabic, and Hungarian texts properly in a PDF by adding tests. Closes DemchaAV#140
|
Hello Joseph, thanks for this PR — the rendered output is a useful baseline validation. I don't personally read Arabic or Hebrew, so I can't fully verify the semantic correctness of text order and shaping from the PDF alone. From the current render:
One caveat: the engine currently has no BiDi reordering or Arabic shaping (text is drawn in logical order), so anything that looks "connected/shaped" shouldn't be read as real shaping yet — I'd treat this as glyph coverage, not correct RTL. So I'd like to land this as baseline Unicode / multilingual rendering coverage, not complete Arabic/Hebrew support. Full Arabic/Hebrew support is tracked in #140 (I'm keeping it open), to be done with:
Housekeeping I did on the PR so you're aware: retargeted the base from Happy to merge this as an important first step. Thanks again! |
Part of #140
Summary
Type of change
Checklist
develop(the integration branch); notmain.<type>/<short-description>(e.g.feature/canvas-clip,fix/table-overflow,docs/recipe-themes); issue-prefixed names like42/fix/short-descriptionare also fine../mvnw -B -ntp clean verifypasses locally.List.getFirst()/getLast(), noThread.threadId(), no switch type / deconstruction patterns, nocase null, default ->. CI matrices Temurin 17 / 21 / 25 and will catch JDK regressions.CHANGELOG.mdentry added under the next## v<X.Y.Z> — Plannedheading.DocumentationCoverageTest.readmeShouldUseCanonicalDslAndAvoidLegacyApisstill passes — canonical fingerprints (GraphCompose.document(,DocumentSession,document.pageFlow(,BusinessTheme) preserved, no legacy tokens (GraphCompose.pdf(,PdfComposer,CvTemplateV1, …)../mvnw -f examples/pom.xml exec:java -Dexec.mainClass=…; if a new example, also added toGenerateAllExamplesand the gallery row count inexamples/README.md.Linked issue
Part of #140