Fix JIRA form processing logic to not skip pushing new findings when finding_jira_sync is enabled #13983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentijnscholten
requested review from
Maffooch and
mtesauro
as code owners
Maffooch
approved these changes
Dec 29, 2025
blakeaowens
approved these changes
Dec 29, 2025
valentijnscholten
changed the title
Jino-T
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Findings were not pushed to JIRA if:
push_to_jiraasTruefinding_jira_syncwas enabled but no JIRA issues was created for the finding yet.This PR simplifies the logic by reusing the helper method
is_keep_in_sync_with_jirafrom the JIRA helper.