Fix CycloneDX XML import failing when vulnerability description is missing #13963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentijnscholten
requested review from
Maffooch and
mtesauro
as code owners
3 tasks
Maffooch
approved these changes
Dec 25, 2025
blakeaowens
approved these changes
Dec 27, 2025
Jino-T
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10249
Description
When uploading a CycloneDX report to DefectDojo, an error was thrown when the vulnerability description field was missing. The CycloneDX specification does not mandate the description field to be present, but DefectDojo requires it in the database.
Root Cause
The
_manage_vulnerability_xml()function (used for CycloneDX 1.4+) did not set a default value for missing descriptions, whilemanage_vulnerability_legacy()(used for CycloneDX 1.0) already had this fix applied in version 2.31.0.Solution
Added a default description when both
descriptionanddetailfields are missing, similar to the legacy function. The default description includes the vulnerability ID and severity.Testing