Skip to content

Conversation

@MMathisLab
Copy link
Member

@MMathisLab MMathisLab commented Jun 13, 2025

  • changed benchmarking link; needs testing. Addresses issue outdated benchmarking link  #118
  • added pytests, general structure, and a test for the benchmarking script

- changed benchmarking link; needs testing
@MMathisLab MMathisLab added dependencies Pull requests that update a dependency file how_to_use_dlclive labels Jun 13, 2025
@sneakers-the-rat
Copy link
Collaborator

Probably need to update the reading code too if it went from tar.gz -> zip?

@MMathisLab
Copy link
Member Author

@maximpavliv if you want to review my code, please do -- but do not push over my code.

Copy link
Collaborator

@maximpavliv maximpavliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for pushing on your PR, I just wanted to fix the method, now it works

@MMathisLab MMathisLab merged commit 44c960f into main Jun 16, 2025
4 checks passed
@MMathisLab MMathisLab deleted the MMathisLab-data branch June 16, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file how_to_use_dlclive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants