Small change to allow replayfiles to be stored in one specific folder, and a security fix#20
Open
cormacj wants to merge 5 commits intoDavidebyzero:masterfrom
Open
Small change to allow replayfiles to be stored in one specific folder, and a security fix#20cormacj wants to merge 5 commits intoDavidebyzero:masterfrom
cormacj wants to merge 5 commits intoDavidebyzero:masterfrom
Conversation
BujuArena
reviewed
Jan 23, 2026
CyberShadow
reviewed
Jan 23, 2026
Author
|
I've updated the PR to reflect the suggested changes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change add an option to allow SnipesGamesFiles to be stored in a specific folder. I added this because I tend to start snipes without checking what folder I'm in. This allows the files to be stored in one place.
I've also updated the filename generation code to use
snprintfinstead ofsprintfto reduce the risk of a buffer overflow if someone supplies too long a folder name.