Fix CI#17
Open
CyberShadow wants to merge 6 commits into
Open
Conversation
This reverts commit caa2ce0. The explanation is wrong; CI was failing due to a regression in its configuration introduced in 07d0ddd. GitHub does not provide any "ubuntu-23.10" runners. The list of runners provided by GitHub is here: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
See previous commit's commit message for details.
…ngGlitch
Fixes:
sdl/console.cpp: In function ‘void FixUpLineJoiningGlitch(SDL_Surface*, Uint8*, bool)’:
sdl/console.cpp:239:59: error: unused parameter ‘HorzLineEdge’ [-Werror=unused-parameter]
239 | static void FixUpLineJoiningGlitch(SDL_Surface *s, Uint8 *HorzLineEdge, bool useRightEdge)
| ~~~~~~~^~~~~~~~~~~~
Fixes:
sdl/console.cpp: In function ‘void RenderCharacterAt(SDL_Renderer*, TTF_Font*, Uint, Uint)’:
sdl/console.cpp:390:19: error: unused variable ‘black’ [-Werror=unused-variable]
390 | SDL_Color black = {0, 0, 0, 0xFF};
| ^~~~~
Fixes:
sdl/console.cpp: In function ‘void ClearGlyphs()’:
sdl/console.cpp:418:9: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
418 | if (SingleHorzLineEdge) delete [] SingleHorzLineEdge; SingleHorzLineEdge = NULL;
| ^~
sdl/console.cpp:418:63: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
418 | if (SingleHorzLineEdge) delete [] SingleHorzLineEdge; SingleHorzLineEdge = NULL;
| ^~~~~~~~~~~~~~~~~~
sdl/console.cpp:419:9: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
419 | if (DoubleHorzLineEdge) delete [] DoubleHorzLineEdge; DoubleHorzLineEdge = NULL;
| ^~
sdl/console.cpp:419:63: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
419 | if (DoubleHorzLineEdge) delete [] DoubleHorzLineEdge; DoubleHorzLineEdge = NULL;
| ^~~~~~~~~~~~~~~~~~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reinstate and fix the GitHub Actions workflow.