[Feature] [admin] 2 new APIs in openapi: 1. create catalogues ,task and send it to DolphinScheduer 2. save task content#3578
Draft
Yangxiaotian wants to merge 35 commits intoDataLinkDC:devfrom
Draft
Conversation
…ition、TaskClient.createTaskDefinition 传入 taskGroupId 参数
github-actions
bot
requested review from
Zzm0809,
aiwenmo,
gaoyan1998 and
zackyoungh
3 tasks
gaoyan1998
requested changes
Jun 7, 2024
| registry.addInterceptor(localeChangeInterceptor()); | ||
| // 注册Sa-Token的路由拦截器 | ||
| registry.addInterceptor(new SaInterceptor(handler -> { | ||
| SaRouter.match("/openapi/**", r -> { |
Contributor
There was a problem hiding this comment.
Don't do this, openapi can't add authentication at the moment, it will cause Dolphinscheduler to be unable to schedule tasks
Contributor
Author
There was a problem hiding this comment.
Yes, I realized this, and the last code was only applying 2 new apis
gaoyan1998
requested changes
Jun 7, 2024
Contributor
gaoyan1998
left a comment
gaoyan1998
left a comment
There was a problem hiding this comment.
Why do you combine create catalog, create job, publish job, push ds function in one interface, this is not reasonable, they do not belong to the same function, should be separate interface
added 2 commits
June 7, 2024 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Refer to this issue: #3482 (comment)
Brief change log
dinky-admin
APIController adds two APIs and sa-token varification.