[Feature] support kyuubi as a datasource#3375
Draft
JiaLiangC wants to merge 1 commit intoDataLinkDC:devfrom
Draft
[Feature] support kyuubi as a datasource#3375JiaLiangC wants to merge 1 commit intoDataLinkDC:devfrom
JiaLiangC wants to merge 1 commit intoDataLinkDC:devfrom
Conversation
github-actions
bot
requested review from
Zzm0809,
aiwenmo,
gaoyan1998 and
zackyoungh
Zzm0809
changed the title
Contributor
|
确实是个好功能，十分期待！有个疑问是怎么做不同engine的语法校验（像sparksql和flilnksql），而且不同engine的查询和写入操作如何区分出来（后续得用于executequery和executeupdate） |
pan3793
reviewed
Jun 7, 2024
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.hive</groupId> | ||
| <artifactId>hive-jdbc</artifactId> |
There was a problem hiding this comment.
kyuubi has its own JDBC driver which is derived from Hive's one, it has zero-deps and fixes many Hive bugs.
pan3793
reviewed
Jun 7, 2024
| public interface KyuubiConstant { | ||
|
|
||
| /** 查询所有database */ | ||
| String QUERY_ALL_DATABASE = " show databases"; |
There was a problem hiding this comment.
I didn't have a deep look at where it is used, but generally, you should rely on standard JDBC API instead of SQL dialect to retrieve such metadata.
Contributor
这个在 dinky 侧普通数据源任务目前做不了语法校验 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Using Kyuubi as the data source and Dinky in a role similar to Hue, it becomes very convenient to query and develop using various big data engines.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: