feat: upgrade the script to installer v12#21
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54f843fc76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| set -euo pipefail | ||
| LANGUAGES="java" SERVICE="my-service" API_KEY="dummy" JAVA_INSTRUMENTED_BUILD_SYSTEM="all" source <(cat script.sh) |
There was a problem hiding this comment.
Remove nounset when sourcing script.sh in CI jobs
Running the wrapper under set -u causes these jobs to fail before any assertions, because script.sh reads optional vars like SITE/DD_SITE and GO_MODULE_DIR using direct expansions ("$VAR") and exits with unbound variable when they are unset. In this commit both test_java_script and .go_smoke_test enable set -euo pipefail and then source the script, so the pipeline aborts immediately (for example: /dev/fd/63: line 25: SITE: unbound variable) instead of exercising installer behavior.
Useful? React with 👍 / 👎.
Summary
GO_MODULE_DIRinput path and pass it through asDD_CIVISIBILITY_GO_MODULE_DIR.DS_StoreGo CI Matrix
The GitLab CI configuration now covers these Go scenarios:
go 1.24go 1.25go 1.22go 1.24, auto-detectedgo 1.25, auto-detectedGO_MODULE_DIRGO_MODULE_DIRGO_MODULE_DIRpointing to a missing directoryThe successful Go jobs run
go test -v ./...withDD_TRACE_DEBUG=trueso the job logs include both verbose test output and tracer debug output.Bug Fix Coverage
This mirrors the v12 upgrade and Go coverage added in DataDog/test-visibility-github-action#60 for the same installer behavior.
In particular, it adds CI coverage for fresh Go
1.24modules, which is the shape involved in DataDog/orchestrion#806, plus equivalent coverage for a single nested Go1.24module and the new multi-module selection flow.Verification
.gitlab-ci.ymlsuccessfullyscript.shpassesbash -ninstall_test_visibility_v12.shscript matches the pinned SHA-256 checksumDD_CIVISIBILITY_GO_MODULE_DIRgo 1.24successgo 1.25successgo 1.22skipgo 1.24auto-detected successGO_MODULE_DIRskip with guidanceGO_MODULE_DIRsuccessGO_MODULE_DIRskip with an error messageNotes
GO_MODULE_DIRcase currently logs an error and skips Go instrumentation, but the wrapper still exits successfully because that is the live v12 installer behaviordocker pullfails on this machine witherror creating temporary lease: write /var/lib/desktop-containerd/daemon/io.containerd.metadata.v1.bolt/meta.db: input/output error