Skip to content

Enable all process discovery tests for Ruby#6637

Open
wantsui wants to merge 1 commit intomainfrom
activate-process-discovery-ruby-tests
Open

Enable all process discovery tests for Ruby#6637
wantsui wants to merge 1 commit intomainfrom
activate-process-discovery-ruby-tests

Conversation

@wantsui
Copy link
Copy Markdown
Contributor

@wantsui wantsui commented Mar 27, 2026

Motivation

I had a bug in DataDog/dd-trace-rb#5504 that wasn't caught by CI and it's because the Ruby Process Discovery Tests wasn't fully enabled.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@wantsui wantsui requested review from a team as code owners March 27, 2026 18:59
@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby

Copy link
Copy Markdown
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants