Skip to content

Auto-activate php easy wins for asm-libraries#6622

Open
dd-octo-sts[bot] wants to merge 1 commit intomainfrom
easy-win/asm-libraries/php
Open

Auto-activate php easy wins for asm-libraries#6622
dd-octo-sts[bot] wants to merge 1 commit intomainfrom
easy-win/asm-libraries/php

Conversation

@dd-octo-sts
Copy link
Copy Markdown
Contributor

@dd-octo-sts dd-octo-sts bot commented Mar 27, 2026

Automated activation of easy-win tests for php owned by asm-libraries
View nightly workflow run

  • If you approve this PR please also merge it.
  • If the tests are failing it might be due to a change made since the last nightly system-tests run. You can close the PR, an updated one will be available tomorrow.
  • If you close the PR please also delete the branch

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dd-octo-sts dd-octo-sts bot requested review from a team as code owners March 27, 2026 17:50
@dd-octo-sts dd-octo-sts bot enabled auto-merge (squash) March 27, 2026 17:50
@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea4abb75ae

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +685 to +689
'*': missing_feature
php-fpm-8.0: '>=1.17.0'
php-fpm-7.1: '>=1.17.0'
apache-mod-7.2-zts: '>=1.17.0'
apache-mod-7.4-zts: '>=1.17.0'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include php-fpm-8.5 in telemetry class activation map

Because weblog_declaration uses '*': missing_feature as a fallback, any omitted weblog stays skipped for the whole class. This block enumerates PHP weblogs for Test_TelemetryMetrics but omits php-fpm-8.5, so all telemetry tests remain missing_feature on that variant even though the newly added method-level rules also omit php-fpm-8.5 (which suggests it was intended to be activated there). Add php-fpm-8.5: '>=1.17.0' to this class-level map to avoid silently dropping the easy-win activation on that weblog.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants