Auto-activate php easy wins for asm-libraries#6622
Auto-activate php easy wins for asm-libraries#6622dd-octo-sts[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea4abb75ae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| '*': missing_feature | ||
| php-fpm-8.0: '>=1.17.0' | ||
| php-fpm-7.1: '>=1.17.0' | ||
| apache-mod-7.2-zts: '>=1.17.0' | ||
| apache-mod-7.4-zts: '>=1.17.0' |
There was a problem hiding this comment.
Include php-fpm-8.5 in telemetry class activation map
Because weblog_declaration uses '*': missing_feature as a fallback, any omitted weblog stays skipped for the whole class. This block enumerates PHP weblogs for Test_TelemetryMetrics but omits php-fpm-8.5, so all telemetry tests remain missing_feature on that variant even though the newly added method-level rules also omit php-fpm-8.5 (which suggests it was intended to be activated there). Add php-fpm-8.5: '>=1.17.0' to this class-level map to avoid silently dropping the easy-win activation on that weblog.
Useful? React with 👍 / 👎.
Automated activation of easy-win tests for
phpowned byasm-librariesView nightly workflow run