Skip to content

chore(ssi): decrease timeout#6612

Open
christophe-papazian wants to merge 1 commit intomainfrom
christophe-papazian/better_timeout
Open

chore(ssi): decrease timeout#6612
christophe-papazian wants to merge 1 commit intomainfrom
christophe-papazian/better_timeout

Conversation

@christophe-papazian
Copy link
Copy Markdown
Contributor

@christophe-papazian christophe-papazian commented Mar 27, 2026

APPSEC-61450

Motivation

Some SSI jobs can rarely froze, and we have to wait for the overall timeout for a failure (30 minutes) while it usually passes under 4 minutes. Decrease the timeout to 8 minutes.

Changes

Decrease the timeout to 8 minutes.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.gitlab/ssi_gitlab-ci.yml                                               @DataDog/system-tests-core
utils/scripts/ci_orchestrators/gitlab_exporter.py                       @DataDog/system-tests-core

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 bot commented Mar 27, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: aee328f | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@christophe-papazian christophe-papazian marked this pull request as ready for review March 27, 2026 19:17
@christophe-papazian christophe-papazian requested a review from a team as a code owner March 27, 2026 19:17
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aee328ffec

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

needs: []
allow_failure: false
timeout: 30 minutes
timeout: 8 minutes
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Increase Docker SSI job timeout budget

Setting .base_docker_ssi_job to timeout: 8 minutes leaves too little wall-clock budget for the job’s own pre-test steps, so Docker SSI runs can now fail with job_execution_timeout even when tests are healthy. The generated script still performs ECR login and SYSTEM_TEST_BUILD_ATTEMPTS=3 SYSTEM_TEST_BUILD_TIMEOUT=240 ./build.sh -i runner before the timeout 460s ./run.sh ... call (utils/scripts/ci_orchestrators/gitlab_exporter.py), which means a cache miss or slow registry/build can consume most of the 8 minutes before run.sh even starts.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant