Conversation
|
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: aee328f | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aee328ffec
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| needs: [] | ||
| allow_failure: false | ||
| timeout: 30 minutes | ||
| timeout: 8 minutes |
There was a problem hiding this comment.
Increase Docker SSI job timeout budget
Setting .base_docker_ssi_job to timeout: 8 minutes leaves too little wall-clock budget for the job’s own pre-test steps, so Docker SSI runs can now fail with job_execution_timeout even when tests are healthy. The generated script still performs ECR login and SYSTEM_TEST_BUILD_ATTEMPTS=3 SYSTEM_TEST_BUILD_TIMEOUT=240 ./build.sh -i runner before the timeout 460s ./run.sh ... call (utils/scripts/ci_orchestrators/gitlab_exporter.py), which means a cache miss or slow registry/build can consume most of the 8 minutes before run.sh even starts.
Useful? React with 👍 / 👎.
APPSEC-61450
Motivation
Some SSI jobs can rarely froze, and we have to wait for the overall timeout for a failure (30 minutes) while it usually passes under 4 minutes. Decrease the timeout to 8 minutes.
Changes
Decrease the timeout to 8 minutes.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present