Fix release tag push and pin actions by SHA#335
Merged
Conversation
The release workflow's tag push was rejected by the tag ruleset because actions/checkout persisted GITHUB_TOKEN credentials, which took precedence over the dd-octo-sts token in the explicit push URL. Drop the persisted credentials and downgrade contents permission to read. Also pin actions/download-artifact and actions/setup-node by commit SHA. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
xopham
requested review from
IlyasShabi,
nsavoire,
r1viollet and
szegedi
as code owners
Overall package sizeSelf size: 2.09 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | node-gyp-build | 4.8.4 | 13.86 kB | 13.86 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
szegedi
approved these changes
May 20, 2026
IlyasShabi
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish_releasejob's tag push was rejected by therefs/tags/*ruleset (see failed run). Root cause:actions/checkoutpersistsGITHUB_TOKENcredentials, which take precedence over the dd-octo-sts token we pass in the explicit push URL. Fix matches the working pattern from sdlc-security-playground: setpersist-credentials: falseon checkout and downgradecontentspermission toread.actions/download-artifact(v4.3.0) andactions/setup-node(v3.9.1) by commit SHA in both jobs.Test plan
v*.xbranch and confirm the workflow tags + pushes successfully via the dd-octo-sts token.🤖 Generated with Claude Code