Skip to content

chore(internal): skip unnecessary config in telemetry#18142

Open
brettlangdon wants to merge 2 commits into
mainfrom
brettlangdon/api.key.telemetry
Open

chore(internal): skip unnecessary config in telemetry#18142
brettlangdon wants to merge 2 commits into
mainfrom
brettlangdon/api.key.telemetry

Conversation

@brettlangdon
Copy link
Copy Markdown
Member

Description

Testing

Risks

Additional Notes

@brettlangdon brettlangdon requested review from a team as code owners May 18, 2026 16:38
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label May 18, 2026
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Codeowners resolved as

ddtrace/internal/settings/_config.py                                    @DataDog/python-guild @DataDog/apm-sdk-capabilities-python
tests/telemetry/test_writer.py                                          @DataDog/apm-python

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 18, 2026

Benchmarks

Benchmark execution time: 2026-05-20 16:18:57

Comparing candidate commit 3727525 in PR branch brettlangdon/api.key.telemetry with baseline commit 0f6f41d in branch main.

Found 0 performance improvements and 6 performance regressions! Performance is the same for 578 metrics, 10 unstable metrics.

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+1.595µs; +1.769µs] or [+7.876%; +8.736%]

scenario:iastaspects-lstrip_aspect

  • 🟥 execution_time [+52.786µs; +57.941µs] or [+19.341%; +21.230%]

scenario:iastaspects-translate_aspect

  • 🟥 execution_time [+57.798µs; +69.818µs] or [+11.876%; +14.345%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+95.786µs; +105.182µs] or [+22.322%; +24.511%]

scenario:span-start

  • 🟥 execution_time [+1.528ms; +1.675ms] or [+9.886%; +10.831%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+275.005ns; +314.320ns] or [+13.329%; +15.235%]

@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1 Bot commented May 20, 2026

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3727525 | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants