Skip to content

chore: update network driver dependency#128

Merged
ken-schneider merged 1 commit into
mainfrom
ken/update-network-driver
May 27, 2026
Merged

chore: update network driver dependency#128
ken-schneider merged 1 commit into
mainfrom
ken/update-network-driver

Conversation

@ken-schneider

@ken-schneider ken-schneider commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Updates the datadog-agent/pkg/network/driver dependency which is needed to allow the original commit in the agent repo to be merged.

Once this is done, we should follow with a new version update in this repo to get us back to the main release track.

Also, I forgot to put the README updates in a separate branch. Assuming this doesn't get backed out, it's fine

Copilot AI review requested due to automatic review settings May 26, 2026 20:32
@ken-schneider ken-schneider requested review from a team and AlexandreYang as code owners May 26, 2026 20:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the traceroute project to consume a newer datadog-agent/pkg/network/driver module revision (required for an upstream agent change), and adjusts Windows driver I/O control usage to match the updated dependency API. It also expands the top-level README with build/run/testing instructions to make the project easier to use locally.

Changes:

  • Bump github.com/DataDog/datadog-agent/pkg/network/driver to v0.81.0-devel... and refresh related Go module dependencies.
  • Update the Windows packet driver source to call SynchronousDeviceIoControl when installing data filters.
  • Add “Getting Started” documentation including build targets, CLI/server usage examples, and flag reference.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
readme.md Adds getting-started/build/usage/testing documentation and updates section heading near downstream usage.
packets/driver_source_windows.go Switches driver IOCTL call to the updated synchronous API for setting filters.
go.mod Updates the driver dependency version and refreshes several related module versions.
go.sum Records new module checksums corresponding to the dependency updates.
Comments suppressed due to low confidence (1)

packets/driver_source_windows.go:92

  • The error returned from SynchronousDeviceIoControl is currently formatted with %v, which discards error wrapping and makes it harder for callers to inspect/root-cause the underlying failure. Elsewhere in this file you consistently wrap errors with %w (e.g., setupSourceDriver).
		err := d.handle.SynchronousDeviceIoControl(
			driver.SetDataFilterIOCTL,
			(*byte)(unsafe.Pointer(&filter)),
			uint32(unsafe.Sizeof(filter)),
			(*byte)(unsafe.Pointer(&id)),
			uint32(unsafe.Sizeof(id)), nil, nil)
		if err != nil {
			return fmt.Errorf("failed to set filter: %v", err)
		}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ken-schneider ken-schneider merged commit 3ceda3e into main May 27, 2026
2 of 3 checks passed
@ken-schneider ken-schneider deleted the ken/update-network-driver branch May 27, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants