chore: update network driver dependency#128
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the traceroute project to consume a newer datadog-agent/pkg/network/driver module revision (required for an upstream agent change), and adjusts Windows driver I/O control usage to match the updated dependency API. It also expands the top-level README with build/run/testing instructions to make the project easier to use locally.
Changes:
- Bump
github.com/DataDog/datadog-agent/pkg/network/drivertov0.81.0-devel...and refresh related Go module dependencies. - Update the Windows packet driver source to call
SynchronousDeviceIoControlwhen installing data filters. - Add “Getting Started” documentation including build targets, CLI/server usage examples, and flag reference.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| readme.md | Adds getting-started/build/usage/testing documentation and updates section heading near downstream usage. |
| packets/driver_source_windows.go | Switches driver IOCTL call to the updated synchronous API for setting filters. |
| go.mod | Updates the driver dependency version and refreshes several related module versions. |
| go.sum | Records new module checksums corresponding to the dependency updates. |
Comments suppressed due to low confidence (1)
packets/driver_source_windows.go:92
- The error returned from
SynchronousDeviceIoControlis currently formatted with%v, which discards error wrapping and makes it harder for callers to inspect/root-cause the underlying failure. Elsewhere in this file you consistently wrap errors with%w(e.g., setupSourceDriver).
err := d.handle.SynchronousDeviceIoControl(
driver.SetDataFilterIOCTL,
(*byte)(unsafe.Pointer(&filter)),
uint32(unsafe.Sizeof(filter)),
(*byte)(unsafe.Pointer(&id)),
uint32(unsafe.Sizeof(id)), nil, nil)
if err != nil {
return fmt.Errorf("failed to set filter: %v", err)
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexandreYang
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
datadog-agent/pkg/network/driverdependency which is needed to allow the original commit in the agent repo to be merged.Once this is done, we should follow with a new version update in this repo to get us back to the main release track.
Also, I forgot to put the README updates in a separate branch. Assuming this doesn't get backed out, it's fine