fix(http): http.url tag should contain the path#663
Merged
florentinl merged 1 commit intomainfrom Oct 14, 2025
Merged
Conversation
florentinl
force-pushed
the
florentin.labelle/APPSEC-59536/fix-http.url-path
branch
2 times, most recently
from
c5d32a0 to
f75eadb
Compare
zarirhamza
reviewed
Oct 14, 2025
datadog_lambda/trigger.py
Outdated
| http_tags["http.url_details.path"] = path | ||
| if http_tags.get("http.url"): | ||
| http_tags["http.url"] += path | ||
| else: |
Contributor
There was a problem hiding this comment.
Does this fallback make sense? Do we want the url to be just the path if the preceding scheme://host cannot be found?
Not sure what the backend logic is here just want to confirm
Contributor
Author
There was a problem hiding this comment.
The spec isn't very clear on if it is intended or not but I could test it with an ALB (case where we have no url) and it works as you would expect.
The backend correctly deduces the http.url_details.path and it is also now deduce the http.pathgroup tag as well.
Contributor
There was a problem hiding this comment.
Yeah lets just make sure the URL tag only has URL since other teams rely on it
florentinl
force-pushed
the
florentin.labelle/APPSEC-59536/fix-http.url-path
branch
from
f75eadb to
6117d29
Compare
zarirhamza
approved these changes
Oct 14, 2025
florentinl
deleted the
florentin.labelle/APPSEC-59536/fix-http.url-path
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
http.url_details.pathtag is set by the backend as described in the span attributes guide of APM. When set by this tracer, it is replaced by the backend by a value parsed from thehttp.urlwhich is always/.Here is an example of a trace received from an API Gateway event where the route can be correctly determined but the path is wrongly set for this reason:
The path should be appended to the
http.urltag instead.Motivation
instead of the expected:
Testing Guidelines
http.urlis only set to the pathAdditional Notes
Types of Changes
Check all that apply