💥 remove trackBfcacheViews and track bfcache restores by default#4228
Draft
BenoitZugmeyer wants to merge 1 commit intov7from
Draft
💥 remove trackBfcacheViews and track bfcache restores by default#4228BenoitZugmeyer wants to merge 1 commit intov7from
BenoitZugmeyer wants to merge 1 commit intov7from
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Bundles Sizes Evolution
🚀 CPU PerformancePending... 🧠 Memory PerformancePending... |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 21b6036 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
The option was introduced as opt-in because it adds a new `bf_cache` loading type to view events, which could surprise customers with existing dashboards or queries not accounting for it. It is now being promoted to default behavior.
cf986a9 to
21b6036
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
trackBfcacheViewswas introduced as an opt-in option because it adds a newbf_cacheloading type to view events, which could surprise customers withexisting dashboards or queries not accounting for it. It is now being promoted
to default behavior.
Changes
trackBfcacheViewsfromRumInitConfigurationandRumConfiguration(i.e.
trackViewsManuallyis not set)track_bfcache_viewsfrom configuration telemetry serializationTest instructions
yarn dev,http://localhost:8080)loading_type: "bf_cache"should be presentChecklist