✅ [RUM-14696] Improve microfrontend e2e test - plugin + module federatoin#4220
✅ [RUM-14696] Improve microfrontend e2e test - plugin + module federatoin#4220amortemousque wants to merge 1 commit intomainfrom
Conversation
|
✨ Fix all issues with BitsAI or with Cursor
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 663b2823fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| createTest('LOAf should have service and version from source code context') | ||
| .withRum(RUM_CONFIG) | ||
| .withSetup(microfrontendSetup) | ||
| .run(async ({ intakeRegistry, flushEvents, page }) => { |
There was a problem hiding this comment.
Skip LOAF assertion outside Chromium
This test now runs the long-task assertion on every Playwright project, but the suite still executes Firefox/WebKit projects and those browsers do not emit the long-task entries this assertion depends on (the repo already guards similar checks with test.skip(browserName !== 'chromium', ...) in other scenarios). As written, rumLongTaskEvents can be empty off Chromium, so the strict toMatchObject([...]) expectation makes this scenario fail in multi-browser runs.
Useful? React with 👍 / 👎.
Motivation
Improve the microfrontend end-to-end test to rely on a real test app configured with Module Federation and the built plugin.
Changes
Test instructions
Checklist