[Do Not Review] TSPS-671 add teaspoons specific service alerts to be shown #5457
[Do Not Review] TSPS-671 add teaspoons specific service alerts to be shown #5457jsotobroad wants to merge 3 commits intodevfrom
Conversation
…ra service alerts for teaspoons portal
There was a problem hiding this comment.
Pull request overview
This PR adds support for displaying teaspoons-specific service alerts by creating a separate alert endpoint for the teaspoons portal. This allows teaspoons users to see alerts with messaging tailored to their platform rather than generic Terra service alerts.
- Added
getTeaspoonsServiceAlerts()method to fetch teaspoons-specific alerts from a new JSON file - Modified
getServiceAlerts()to conditionally fetch teaspoons or Terra alerts based on the current brand
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libs/ajax/firecloud/FirecloudBucket.ts | Added new method to fetch teaspoons-specific service alerts from teaspoons-alerts.json |
| src/alerts/service-alerts.ts | Updated to conditionally fetch teaspoons or Terra alerts based on brand detection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const serviceAlerts = isScientificServices() | ||
| ? await FirecloudBucket().getTeaspoonsServiceAlerts() | ||
| : await FirecloudBucket().getServiceAlerts(); |
There was a problem hiding this comment.
The conditional logic for fetching different service alerts based on brand lacks test coverage. Consider adding tests to verify that the correct alert endpoint is called for both teaspoons (isScientificServices() === true) and Terra (isScientificServices() === false) brands.
|
2 participants
Jira Ticket: https://broadworkbench.atlassian.net/browse/TSPS-671
Summary of changes:
Adding the ability to display teaspoons specific service alerts for the teaspoons portal
What
Why
Testing strategy
Currently still waiting for some beehive changes to be able to test out the full functionality (beehive will write the teaspoons-alerts.json file)