[IA-4840] [DO NOT MERGE] Testing running jupyter server from docker container for ToA#4465
Closed
[IA-4840] [DO NOT MERGE] Testing running jupyter server from docker container for ToA#4465
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4465 +/- ##
========================================
Coverage 73.99% 73.99%
========================================
Files 159 159
Lines 14784 14784
Branches 1231 1231
========================================
Hits 10939 10939
Misses 3845 3845 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
LizBaldo
commented
Apr 25, 2024
LizBaldo
commented
Apr 25, 2024
lucymcnatt
approved these changes
May 1, 2024
Collaborator
lucymcnatt
left a comment
There was a problem hiding this comment.
Some small questions, otherwise lgtm
Collaborator
Author
|
@lucymcnatt and @cpate4 everything is working now and ready for a final review, albeit with a need for a lot of bash gymnastic 😭 LMK what you think! |
cindy-broadinstitute
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/IA-4840
Summary of changes
What
Why
Testing these changes
I deployed this branch on my BEE (
ebaldo) and can successfully create a running Jupyter Runtime on Azure 🎉 and verified that Welder is working, and I can successfully pause and resume the runtime.