docs+fix: ATLAS-CONTRACT.md v1.1.0 + fix two wrong atlas calls in doctor.zsh#468
Draft
Data-Wise wants to merge 2 commits into
Draft
docs+fix: ATLAS-CONTRACT.md v1.1.0 + fix two wrong atlas calls in doctor.zsh#468Data-Wise wants to merge 2 commits into
Data-Wise wants to merge 2 commits into
Conversation
ATLAS-CONTRACT.md (v1.0.0 → v1.1.0): - Add Version Compatibility row: flow-cli v7.10.x ↔ atlas v0.9.3 - Document 5 new contracted flags (session status --format, project list --count, project list --suggest, inbox --count, trail --limit) - Add `atlas session status` to Warm Path Commands table - Replace universal --format claim with per-command support matrix (project list: table|json|names; project show: +shell; session status: table|json; stats: table|json|text|md; session export: ical|json) - Add contract sections for each new flag with exact output semantics - Update Parties line to v7.10.x / v0.9.3 commands/doctor.zsh (OOS-1, OOS-2): - OOS-1: replace `atlas config get backend` (non-existent subcommand) with `atlas config show | jq '.storage'` (with grep/sed fallback) - OOS-2: replace `atlas mcp status` (non-existent subcommand) with `command -v atlas-mcp` (atlas-mcp is a separate binary declared in atlas package.json bin, not an atlas subcommand) Co-Authored-By: Claude (scheduled agent) <noreply@anthropic.com>
… parse; document config show Addresses the adversarial review of the atlas-contract-v1.1 changes. Verified against atlas source (bin/atlas.js:1122 — config show emits JSON.stringify(cfg, null, 2); package.json bin — atlas-mcp is a separate binary), so the OOS-1/OOS-2 fixes are confirmed correct. Remaining issues fixed: - doctor.zsh: '✓ connected' fired whenever 'command -v atlas' succeeded, so a broken/half-installed atlas (e.g. bad interpreter shebang) was reported as connected. Now gated on 'atlas config show' actually returning output; a non-responding atlas shows '⚠ installed but not responding'. Verified against the local broken atlas. - doctor.zsh: anchored the no-jq .storage parse on the "storage" key so it doesn't greedily capture the last quoted value (wrong for compact JSON). - ATLAS-CONTRACT.md: documented 'atlas config show' (which doctor.zsh depends on) — full config as pretty JSON, '.storage' is the backend (filesystem|sqlite), no 'atlas config get' subcommand exists. - tests/test-doctor-atlas-calls.zsh: static spec-compliance regression guard (no working-atlas/jq dependency); registered in run-all.sh. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Data-Wise
pushed a commit
that referenced
this pull request
Jun 14, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
Fixes pushed (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/ATLAS-CONTRACT.mdfrom v1.0.0 to v1.1.0, documenting the 5 new atlas v0.9.3 integration flags and correcting the output-format section from a false universal-flag claim to a per-command support matrix.commands/doctor.zshthat would silently fail for any user with atlas installed (OOS-1:atlas config get backend→atlas config show; OOS-2:atlas mcp status→command -v atlas-mcp).Changes
docs/ATLAS-CONTRACT.md(v1.0.0 → v1.1.0)atlas session statusrow (previously absent entirely); addedatlas trail --limit <n>row.atlas inbox --countrow alongside existingatlas inbox.--formatflag" claim with a per-command support matrix:project list:table | json | namesproject show:table | json | names | shellsession status:table | json(NEW)stats:table | json | text | mdsession export:ical | jsonplan:--jsonflag (not--format)session status --format=json,project list --count,project list --suggest,inbox --count,trail --limit).commands/doctor.zshatlas config get backend):atlas confighas nogetsubcommand. The correct command isatlas config show, which emits JSON containing astoragefield (the backend). Fixed toatlas config show | jq -r '.storage'with agrep/sedfallback whenjqis absent. Diagnostic remains non-fatal.atlas mcp status):atlashas nomcpsubcommand. The MCP server is a separate binaryatlas-mcp(declared in atlas'spackage.jsonbin). Fixed tocommand -v atlas-mcp. Message updated to "atlas-mcp binary available" vs "(optional MCP server, not installed)".Decision recorded
The task brief noted these as pre-approved fixes. No behaviour changes to flow-cli's hot-path; both doctor checks are non-fatal diagnostics.
Test plan
source flow.plugin.zsh && doctor— atlas integration section should show backend fromconfig showinstead of erroringdoctorwith atlas installed butjqabsent — sed fallback produces same resultdoctorwith atlas not installed — section still shows "optional, not installed" gracefullydoctoroutput references "atlas-mcp binary available" / "optional MCP server, not installed" (no longer callsatlas mcp status)./tests/run-all.sh— no regressions (doctor tests are non-interactive, should still pass)https://claude.ai/code/session_01FuHPHhpeCDgcowKPnG2F4V
Generated by Claude Code