ci: promote full-suite to a required gate (Phase 3)#466
Merged
Conversation
The full-suite job (run-all.sh) has soaked green on dev (PR #465). Drop continue-on-error so a real failure now fails the check, and rename the job "Full Test Suite (non-blocking)" -> "Full Test Suite" so the required-check name is honest. Service/tool-absent suites still clean-skip via rc 77, so a non-zero exit is a genuine regression. Next: add "Full Test Suite" to dev branch protection (this PR's run registers the renamed check); main protection follows after a dev soak. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phase 3 of the CI full-suite gate. The
full-suitejob (./tests/run-all.sh) has soaked green on dev (merged via #465). This makes it a real blocking gate:continue-on-error: true→ a real failure now fails the check.Full Test Suite (non-blocking)→Full Test Suiteso the required-check name is honest.Service/tool-absent suites still clean-skip via rc 77, so a non-zero exit is a genuine regression — not an environment artifact.
After this merges
Full Test Suitetodevbranch protection (this PR's CI run registers the renamed check so it's selectable).mainbranch protection follows after a further soak (separate, confirmed step).Verification
run-all.shis green on the dev runner: 64 passed, 0 failed, 0 timeout, 1 skipped (exit 0). This PR's ownFull Test Suiterun is the registration + soak.🤖 Generated with Claude Code