Skip to content

Fix listener lifecycle management#90

Merged
Darkroom4364 merged 1 commit into
devfrom
issue/86-listener-lifecycle
May 29, 2026
Merged

Fix listener lifecycle management#90
Darkroom4364 merged 1 commit into
devfrom
issue/86-listener-lifecycle

Conversation

@Darkroom4364

Copy link
Copy Markdown
Owner

Summary\n- make HTTP/HTTPS listener start bind synchronously and store the concrete net.Listener/http.Server handles\n- stop/restart/delete listeners through graceful server shutdown with explicit socket cleanup\n- reject duplicate listener names and failed starts before registry insertion\n- remove dead placeholder connection/protocol/listener types from active server code\n- add listener lifecycle, bind failure, duplicate name, TLS failure, concurrency, JSON snapshot, and race-oriented tests\n\n## Validation\n- go test ./...\n- go vet ./...\n- go test -race ./internal/listeners\n- go test -count=10 ./internal/listeners\n- go build -o /private/tmp/microc2-server-issue86 ./cmd\n\nCloses #86

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1bef2635-a1a4-494d-92ac-2c41eadd17db

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue/86-listener-lifecycle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Darkroom4364 Darkroom4364 merged commit f34ee46 into dev May 29, 2026
10 of 11 checks passed
@Darkroom4364 Darkroom4364 deleted the issue/86-listener-lifecycle branch May 29, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant