Skip to content

Update post comment empty state in PostScreen #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuni-ju merged 3 commits into from
Apr 28, 2026
Merged

Update post comment empty state in PostScreen #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24cc892
#1063 [QA] Update description text style
yuni-ju Apr 27, 2026
e5a9a48
#1063 [QA] Add spacer to post comment empty state
yuni-ju Apr 27, 2026
6ff4949
[QA] Update comment empty description string
yuni-ju Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions presentation/src/main/java/daily/dayo/presentation/view/Comment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,13 @@ fun CommentListView(

Text(
text = stringResource(id = R.string.post_comment_empty),
style = DayoTheme.typography.b3.copy(Gray3_9FA5AE),
style = DayoTheme.typography.b5.copy(Gray2_767B83),
modifier = Modifier.padding(top = 12.dp, bottom = 2.dp)
)
Spacer(Modifier.height(2.dp))
Text(
text = stringResource(id = R.string.post_comment_empty_description),
style = DayoTheme.typography.caption1.copy(Gray4_C5CAD2)
style = DayoTheme.typography.caption4.copy(Gray3_9FA5AE)
)
}
} else {
Expand Down
2 changes: 1 addition & 1 deletion presentation/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
<string name="post_comment_count_message">개의 댓글</string>
<string name="post_contents_more">더보기</string>
<string name="post_comment_empty">아직 댓글이 없어요</string>
<string name="post_comment_empty_description">이 게시글에 대해 댓글을 남겨주세요</string>
<string name="post_comment_empty_description">첫번째 댓글을 남겨보세요</string>
<string name="post_option_mine_modify">게시물 수정</string>
<string name="post_option_mine_delete">게시물 삭제</string>
<string name="post_option_mine_delete_alert_description">이 게시글을 정말 삭제할까요?</string>
Expand Down
Loading