Implement nonce cleanup functionality with tests#673
Open
somotochukwu-dev wants to merge 1 commit into
Open
Conversation
|
@Dubemtopsite is attempting to deploy a commit to the mAzI's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@somotochukwu-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #465
Summary
Implements BE-W3A-111: Cryptographic Nonce Garbage Collection Cron Job + fixes merge artifacts in
auth.tsand the brokenpackage.json.Changes
backend/src/utils/nonce-cleanup.ts(new)Promise.all:auth_challenges— expired challenges (nonces)sessions— expired sessionsrefresh_tokens— expired or revoked tokensNONCE_CLEANUP_INTERVAL_MSenv var (default: 5 min)storage-cleanup.tspattern with tracing, stats, andunref()'d timerstartNonceCleanup(),stopNonceCleanup(),getNonceCleanupStats()backend/src/routes/auth.ts/verifyhandler — lines 693–782 were a broken merge artifact that shadowed the real handler with a simplified version missing refresh token rotation and session trackingdecodeSignature(raw: string)function embedded insideextractSignatureStringisSessionRevoked(redis, token)— exported Redis blacklist lookup with 5ms timeout budget (matches existing test expectations)createAuthRouter({ prismaClient?, redisClient? })— dependency-injection factory that overrides the module-level DB and Redis references, enabling test mocking without module-patching hacksdbbinding instead of the constprismaimport, transparently supporting DIbackend/src/index.tsstartNonceCleanup()inbootstrap()alongside the storage cleanup jobstopNonceCleanup()in SIGTERM handlerbackend/package.json"scripts"object made the file unparseable by npmbackend/tests/nonce-cleanup.test.ts(new)Testing
auth.test.ts,sep10-compliance.test.ts, andfailover-pool.test.tsare unrelated)pool-enhanced.ts)Acceptance Criteria Covered
isSessionRevokedwithBLACKLIST_TIMEOUT_MS = 5)