Skip to content

Use inline expressions instead of User Parameters for parametric dogbones #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ksperling wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use inline expressions instead of User Parameters for parametric dogbones #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
894bc27
Don't use User Variables for parametric dogbones.
ksperling May 25, 2019
cb49f51
Fix temporary hole suppression to only un-suppress newly created holes
ksperling May 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 19 additions & 72 deletions Dogbone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,63 +596,8 @@ def onExecute(self, args):
self.writeDefaults()

if self.parametric:
userParams = adsk.fusion.UserParameters.cast(self.design.userParameters)

#set up parameters, so that changes can be easily made after dogbones have been inserted
if not userParams.itemByName('dbToolDia'):
dValIn = adsk.core.ValueInput.createByString(self.circStr)
dParameter = userParams.add('dbToolDia', dValIn, self.design.unitsManager.defaultLengthUnits, '')
dParameter.isFavorite = True
else:
uParam = userParams.itemByName('dbToolDia')
uParam.expression = self.circStr
uParam.isFavorite = True

if not userParams.itemByName('dbOffset'):
rValIn = adsk.core.ValueInput.createByString(self.offStr)
rParameter = userParams.add('dbOffset',rValIn, self.design.unitsManager.defaultLengthUnits, 'Do NOT change formula')
else:
uParam = userParams.itemByName('dbOffset')
uParam.expression = self.offStr
uParam.comment = 'Do NOT change formula'

if not userParams.itemByName('dbRadius'):
rValIn = adsk.core.ValueInput.createByString('(dbToolDia + dbOffset)/2')
rParameter = userParams.add('dbRadius',rValIn, self.design.unitsManager.defaultLengthUnits, 'Do NOT change formula')
else:
uParam = userParams.itemByName('dbRadius')
uParam.expression = '(dbToolDia + dbOffset)/2'
uParam.comment = 'Do NOT change formula'

if not userParams.itemByName('dbMinPercent'):
rValIn = adsk.core.ValueInput.createByReal(self.minimalPercent)
rParameter = userParams.add('dbMinPercent',rValIn, '', '')
rParameter.isFavorite = True
else:
uParam = userParams.itemByName('dbMinPercent')
uParam.value = self.minimalPercent
uParam.comment = ''
uParam.isFavorite = True

if not userParams.itemByName('dbHoleOffset'):
oValIn = adsk.core.ValueInput.createByString('dbRadius / sqrt(2)' + (' * (1 + dbMinPercent/100)') if self.dbType == 'Minimal Dogbone' else 'dbRadius' if self.dbType == 'Mortise Dogbone' else 'dbRadius / sqrt(2)')
oParameter = userParams.add('dbHoleOffset', oValIn, self.design.unitsManager.defaultLengthUnits, 'Do NOT change formula')
else:
uParam = userParams.itemByName('dbHoleOffset')
uParam.expression = 'dbRadius / sqrt(2)' + (' * (1 + dbMinPercent/100)') if self.dbType == 'Minimal Dogbone' else 'dbRadius' if self.dbType == 'Mortise Dogbone' else 'dbRadius / sqrt(2)'
uParam.comment = 'Do NOT change formula'

self.radius = userParams.itemByName('dbRadius').value
self.offset = adsk.core.ValueInput.createByString('dbOffset')
self.offset = adsk.core.ValueInput.createByReal(userParams.itemByName('dbHoleOffset').value)

self.createParametricDogbones()

else: #Static dogbones

self.radius = (self.circVal + self.offVal) / 2
self.offset = self.radius / sqrt(2) * (1 + self.minimalPercent/100) if self.dbType == 'Minimal Dogbone' else self.radius if self.dbType == 'Mortise Dogbone' else self.radius / sqrt(2)

else:
self.createStaticDogbones()

self.logger.info('all dogbones complete\n-------------------------------------------\n')
Expand Down Expand Up @@ -805,9 +750,16 @@ def createParametricDogbones(self):
self.errorCount = 0
if not self.design:
raise RuntimeError('No active Fusion design')
holeInput = adsk.fusion.HoleFeatureInput.cast(None)
offsetByStr = adsk.core.ValueInput.createByString('dbHoleOffset')
centreDistance = self.radius*(1+self.minimalPercent/100 if self.dbType=='Minimal Dogbone' else 1)

holeDiaExpr = '({}) + ({})'.format(self.circStr, self.offStr)
holeOffsetExpr = (
'({}) / 2'.format(holeDiaExpr) if self.dbType == 'Mortise Dogbone' else
'({}) / sqrt(8) * {:.3f}'.format(holeDiaExpr, 1 + self.minimalPercent / 100.0) if self.dbType == 'Minimal Dogbone' else
'({}) / sqrt(8)'.format(holeDiaExpr))

diaByStr = adsk.core.ValueInput.createByString(holeDiaExpr)
offsetByStr = adsk.core.ValueInput.createByString(holeOffsetExpr)
suppressedHoles = []

for occurrenceFace in self.selectedOccurrences.values():
startTlMarker = self.design.timeline.markerPosition
Expand Down Expand Up @@ -892,11 +844,6 @@ def createParametricDogbones(self):

selectedEdgeFaces = makeNative(selectedEdge.edge).faces

dirVect = adsk.core.Vector3D.cast(dbUtils.getFaceNormal(selectedEdgeFaces[0]).copy())
dirVect.add(dbUtils.getFaceNormal(selectedEdgeFaces[1]))
dirVect.normalize()
dirVect.scaleBy(centreDistance) #ideally radius should be linked to parameters,

if self.dbType == 'Mortise Dogbone':
direction0 = dbUtils.correctedEdgeVector(edge1,startVertex)
direction1 = dbUtils.correctedEdgeVector(edge2,startVertex)
Expand Down Expand Up @@ -938,7 +885,7 @@ def createParametricDogbones(self):
holePlane = makeNative(face)

holes = comp.features.holeFeatures
holeInput = holes.createSimpleInput(adsk.core.ValueInput.createByString('dbRadius*2'))
holeInput = holes.createSimpleInput(diaByStr)
# holeInput.creationOccurrence = occ #This needs to be uncommented once AD fixes component copy issue!!
holeInput.isDefaultDirection = True
holeInput.tipAngle = adsk.core.ValueInput.createByString('180 deg')
Expand All @@ -954,11 +901,10 @@ def createParametricDogbones(self):
holeFeature = holes.add(holeInput)
holeFeature.name = 'dogbone'
holeFeature.isSuppressed = True
suppressedHoles.append(holeFeature)

for hole in holes:
if hole.name[:7] != 'dogbone':
break
hole.isSuppressed = False
for hole in suppressedHoles:
hole.isSuppressed = False

endTlMarker = self.design.timeline.markerPosition-1
if endTlMarker - startTlMarker >0:
Expand All @@ -975,8 +921,9 @@ def createStaticDogbones(self):
self.errorCount = 0
if not self.design:
raise RuntimeError('No active Fusion design')
holeInput = adsk.fusion.HoleFeatureInput.cast(None)
centreDistance = self.radius*(1+self.minimalPercent/100 if self.dbType == 'Minimal Dogbone' else 1)

radius = (self.circVal + self.offVal) / 2
centreDistance = radius*(1+self.minimalPercent/100 if self.dbType == 'Minimal Dogbone' else 1)

for occurrenceFace in self.selectedOccurrences.values():
startTlMarker = self.design.timeline.markerPosition
Expand Down Expand Up @@ -1113,7 +1060,7 @@ def createStaticDogbones(self):
face = reValidateFace(comp, selectedFace.refPoint)

holes = comp.features.holeFeatures
holeInput = holes.createSimpleInput(adsk.core.ValueInput.createByReal(self.radius*2))
holeInput = holes.createSimpleInput(adsk.core.ValueInput.createByReal(radius*2))
holeInput.isDefaultDirection = True
holeInput.tipAngle = adsk.core.ValueInput.createByString('180 deg')
holeInput.participantBodies = [face.body]
Expand Down