Add readme comment about Crashlytics #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSteve595
reviewed
Dec 11, 2019
| - Place your API key and client ID into `app/src/main/res/secrets.xml`. | ||
| - Comment out these 2 lines in `app/build.gradle` (don't commit these changes): | ||
| - `apply plugin: 'io.fabric'` | ||
| - `apply plugin: 'com.google.gms.google-services'` |
Owner
There was a problem hiding this comment.
Actually, we can conditionally apply these plugins if the file is present, that might be friendlier
Contributor
Author
There was a problem hiding this comment.
That'd be better indeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build was failing because there's no Google Services json file in the project.
Commenting out Fabric and Google Services in build.gradle worked.