Implemented REST APIs to manage ideas#121
Merged
david-poindexter merged 10 commits intoDNNCommunity:developfrom Feb 3, 2026
Merged
Implemented REST APIs to manage ideas#121david-poindexter merged 10 commits intoDNNCommunity:developfrom
david-poindexter merged 10 commits intoDNNCommunity:developfrom
Conversation
Also includes integratino tests. Closes DNNCommunity#115 Closes DNNCommunity#116
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements REST APIs for managing ideas, including operations to create, update, search, and soft-delete ideas. It also includes comprehensive integration tests as requested in issue #116.
Changes:
- Implemented REST API controller (IdeaController) with endpoints for saving, searching, getting details, and requesting deletion of ideas
- Added integration tests covering all scenarios from issue #116 including permission checks, search functionality, and admin capabilities
- Generated TypeScript client code for frontend consumption
- Added request context abstraction (DnnRequestContext) for accessing DNN platform information
- Consolidated ValidationProblemDetails into ProblemDetails base class
Reviewed changes
Copilot reviewed 21 out of 26 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| Controllers/IdeaController.cs | New REST API controller implementing idea management endpoints |
| Controllers/Context/DnnRequestContext.cs | New context provider for accessing current request information |
| Controllers/Context/IDnnRequestContext.cs | Interface for request context abstraction |
| module.web/src/services/services.ts | Auto-generated TypeScript client for REST APIs |
| IntegrationTests/Controllers/IdeaControllerTests.cs | Comprehensive integration tests covering all requirements from issue #116 |
| IntegrationTests/FakeControllerContext.cs | Test infrastructure for controller integration tests |
| Services/Ideas/IdeaService.cs | Fixed ordering issue - now consistently orders results by CreatedAt |
| Entities/ProblemDetails/ProblemDetails.cs | Added Errors collection to base class |
| Extensions/ApiControllerExtensions.cs | New extension method for creating BadRequest responses with error details |
| resources/App_LocalResources/ModelValidation.resx | Added ValidationErrorTitle resource string |
Files not reviewed (1)
- module.web/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also includes integration tests.
Closes #115
Closes #116