[week06]발베니 6주차 미션1#125
Open
Seongmin0218 wants to merge 1 commit into
Open
Conversation
Eunjin03
reviewed
May 12, 2026
Contributor
Eunjin03
left a comment
Eunjin03
left a comment
There was a problem hiding this comment.
안녕하세요! 6주차도 고생많으셨습니다.
늘 코드를 엄청 깔끔하게 작성하시는 것 같습니다! 디렉토리 구조화도 잘 되어있구요 ㅎㅎ
lp detail page는 만드셨는데 실행 영상에 함께 첨부가 안되어있더라구요 ㅠㅠ 다음엔 꼭 같이 넣어서 보여주세요!! 사실 제가 보고싶어서요..ㅎㅎ
7주차도 화이팅입니다!
|
|
||
| {isLoggedIn ? ( | ||
| <> | ||
| {/* 마이페이지 */} |
Contributor
There was a problem hiding this comment.
미션에는 해당 부분이 "~님 환영합니다" 식으로 바뀌었더라고요! 반영 부탁드립니당
Contributor
There was a problem hiding this comment.
전반적으로 쿼리 코드 넘 잘짜셨네요! 파일 분리도 잘하셨습니다
| </div> | ||
|
|
||
| <div className="grid grid-cols-2 gap-4 sm:grid-cols-[repeat(auto-fill,minmax(180px,1fr))] md:grid-cols-[repeat(auto-fill,minmax(200px,1fr))]"> | ||
| {lpList.map((lp: LpItem) => { |
Contributor
There was a problem hiding this comment.
lp component를 분리하여 사용하는 것도 좋은 방법일 것 같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.