[Week07] 징징이 7주차 미션#19
Open
junjinyun wants to merge 4 commits into
Open
Conversation
yousung1020
reviewed
May 14, 2026
Contributor
yousung1020
left a comment
yousung1020
left a comment
There was a problem hiding this comment.
수고많으셨습니다! 전반적으로 수용력 및 응용력이 훌륭하신 것 같아요! 매우 깔끔하고 좋은 코드인 것 같으나, 일부 피드백 사항만 적용되면 더욱 좋을 것 같아요!
| public static ReviewPreviewListResponse toReviewPreviewListResponse(Slice<StoreReview> reviewSlice) { | ||
| List<ReviewResponse> reviewResponseList = reviewSlice.getContent().stream() | ||
| .map(review -> toReviewResponse(review, new ArrayList<>())) | ||
| .collect(Collectors.toList()); |
| public CommonResponse<Void> addUserInterests( | ||
| @PathVariable Long userId, | ||
| @RequestBody @NotEmpty(message = "최소 하나 이상의 관심사 ID가 필요합니다.") List<Long> request) { | ||
| @RequestBody @Valid @NotEmpty(message = "최소 하나 이상의 관심사 ID가 필요합니다.") List<Long> request) { |
Contributor
There was a problem hiding this comment.
코드의 확장성 및 일관성을 위해 @NotEmpty를 dto 필드 단으로 옮겨주세요!
Contributor
|
전체적으로 간결하고 좋은 코드인 것 같습니다! |
Contributor
|
너무 좋습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
페이징 기능에 대해 어떤 차이가 있는지 정도만 알고 있던 상태에서 각각 서로 다른 페이징을 직접 구현 해 보니 둘의 차이나 코드 상의 차이점에 대해 더 잘 알게 된거 같아 좋았음.