psvr2: initialize fallback distortion rotation scales#3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
k3/k4) to be zero and could collapse UV sampling and make one eye render incorrectly compared to the other.Description
calibration_block.version_unk < 4, initializehmd->distortion_calibration[4]andhmd->distortion_calibration[6]to1.0fso the rotation/tilt scale is the identity for both eyes.memsetleaves the sine (tilt) terms at zero, so this change produces an identity rotation (cos = 1,sin = 0) for fallback cases.psvr2_compute_distortion_asymmetricreceives validk3/k4values and prevents UV collapse around the lens center.Testing
psvr2_setup_distortion_and_fovsandpsvr2_compute_distortion_asymmetricby source inspection and confirmed the new values flow into the distortion computation (inspection succeeded).ninja -C build -t targetsbut the command failed due to a missingbuild/build.ninjain the workspace (build-target enumeration failed).Codex Task