Open
Conversation
**Fix** 1.double time error and use nanoseconds() 2.prevent repeated wheel delta integration in imu callback **Result** local_pose error within 2cm
- repname parameter ```side``` in ```lidar_member_function.py``` to ```mode``` - change ```self.side``` type to string - change firmware port name - specify topics in ros1_bridge
- decrease queue size of ros1 bridge to 1 - rename topic names when bag testing - get param ```mode``` in launch - mount folders to contain things for colcon build
- add launch files for every localization layer - install `param` in CMakeLists.txt to use `find-pkg-share` in launch files - remove old launch files - rename `lidar_localization.yml` to `lidar_localization.yaml` for consistency - haven't refactor launch settings for rival localization
get current time from ros time instead of system time, to make sure the time is consistent with ros messages.
- use `lidar_multiplier` parameter to calibrate lidar scan range - add adaptive measurement covariance to ignore camera yaw - assign lidar yaw to camera yaw when ekf update
- `map` to `odom` frame as static transform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A code review branch