.observe() bug fix, unbindAfterIntersect setting added#2
Open
aladage wants to merge 11 commits into
Open
Conversation
…d no elements to begin with
aladage
requested review from
JMW5,
briangraves,
designbykhalid,
heaper,
jlawhorn,
kylegeary and
scheul93
jlawhorn
approved these changes
Nov 21, 2018
heaper
approved these changes
Nov 21, 2018
heaper
reviewed
Nov 21, 2018
| const observe = els => { | ||
| const onNonIntersection = el => { | ||
| if (settings.onNonIntersectionCallback !== null && | ||
| initialIntersection === false) { |
Contributor
There was a problem hiding this comment.
What happens if the element is within the viewport at page load, and then the user scrolls down the page and the element leaves the viewport? You'd probably want the non-intersection callback to fire in that scenario, but I don't think it would because initialIntersection would be true.
Contributor
There was a problem hiding this comment.
Maybe also setting initialIntersection to false in your load() method would solve this problem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.