Skip to content

FSR-1603 | Node Upgrade to V22 #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeeGordon83 wants to merge 5 commits into
base: development
Choose a base branch
from
Open

FSR-1603 | Node Upgrade to V22 #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c8041d
updated node version to 22 and bumped all out of date npm packages
LeeGordon83 Feb 12, 2026
c5b741d
fixed failing test
LeeGordon83 Feb 16, 2026
34adf26
fixed leaks in unit tests
LeeGordon83 Feb 16, 2026
fdd0d10
added unit test coverage for rloi-process
LeeGordon83 Feb 17, 2026
1afe53d
fixed linting
LeeGordon83 Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v20
v22
13 changes: 12 additions & 1 deletion lib/functions/rloi-process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,18 @@ module.exports.handler = async (event) => {
const bucket = event.Records[0].s3.bucket.name
const key = event.Records[0].s3.object.key
const data = await s3.getObject({ Bucket: bucket, Key: key })
const bodyContents = await data.Body.transformToString()
let bodyContents = ''
if (data.Body && typeof data.Body.transformToString === 'function') {
// Test mock or AWS SDK v3 convenience method
bodyContents = await data.Body.transformToString()
} else if (data.Body && typeof data.Body[Symbol.asyncIterator] === 'function') {
// Node.js stream (production)
for await (const chunk of data.Body) {
bodyContents += chunk
}
} else {
throw new Error('data.Body is not async iterable and has no transformToString method')
}
const file = await util.parseXml(bodyContents)

// use pool and not client due to multiple database queries
Expand Down
Loading