Conversation
There was a problem hiding this comment.
Pull request overview
This is a major refactoring effort that modernizes and standardizes the PolyBus messaging framework across TypeScript, Python, and .NET implementations. The refactoring focuses on improving API consistency, simplifying interfaces, and enhancing error handling.
Key changes:
- Renamed core methods and properties for clarity (
addOutgoingMessage→add,incomingHandlers→incomingPipeline) - Split transaction factories into separate incoming/outgoing factories
- Changed Messages API from returning nullable types to throwing specific errors
- Restructured in-memory transport into broker/endpoint pattern
- Simplified JSON handlers by removing configuration flags
- Added new error types for better error categorization
Reviewed changes
Copilot reviewed 104 out of 104 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| TypeScript transaction files | Renamed addOutgoingMessage to add, simplified endpoint resolution |
| TypeScript message files | Added messageInfo property, changed Messages methods to throw errors |
| TypeScript transport interface | Renamed send to handle, added deadLetterEndpoint, renamed properties |
| TypeScript in-memory transport | Split into InMemoryMessageBroker and InMemoryEndpoint classes |
| TypeScript error handlers | Renamed delay to delayIncrement, improved logging |
| TypeScript JSON handlers | Removed throwOnMissingType and throwOnInvalidType flags |
| TypeScript tests | Simplified and updated to match new APIs |
| Python implementation | Mirrors TypeScript changes with Python conventions |
| .NET implementation | Mirrors TypeScript changes with C# conventions |
| Documentation | Updated README files to remove detailed project structure sections |
src/dotnet/PolyBus/Transport/Transactions/Messages/Handlers/Error/ErrorHandler.cs
Show resolved
Hide resolved
src/python/tests/transport/transaction/message/handlers/serializers/test_json_handlers.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.