p2p: TODO or add peer ban behaviour#620
Open
redsh4de wants to merge 6 commits into
Open
Conversation
57e39c7 to
a8fbfae
Compare
a8fbfae to
98577a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add ban behaviours from monerod, or TODOs in places where bans would be needed but would require ban system upgrades.
Why
Consistency, documentation for future upgrades
Where
cuprated,p2pHow
New bans added for places where monerod drops connection with a ban score contribution (
drop_connection(_,true,_)).SHORT_BANcryptonote_protocol_handler.inl:782-794MEDIUM_BANcryptonote_protocol_handler.inl:2544-2549MEDIUM_BANcryptonote_protocol_handler.inl:1071-1077TODOs added in places where monerod contributes to the ban score accumulator (
add_host_fail/hit_score), and triggers a ban only after repeated violations. Needs ban system upgrades, as currently it's either ban or do nothing.current_blockchain_heightregression (3 sites:new_fluffy_block, timed-sync request, timed-sync response)cryptonote_protocol_handler.inl:466-470cryptonote_protocol_handler.inl:1087-1091cryptonote_protocol_handler.inl:2509-2513net_node.inl:2587-2594net_node.inl:1170-1175net_node.inl:1250-1255