Skip to content

http flush and error handling on discord webhook callback #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cufee merged 1 commit into from
Apr 2, 2026
Merged

http flush and error handling on discord webhook callback #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions cmd/discord/router/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
"github.com/bwmarrin/discordgo"
"github.com/cufee/aftermath/cmd/discord/commands/builder"
"github.com/cufee/aftermath/cmd/discord/common"
"github.com/cufee/aftermath/cmd/discord/rest"
"github.com/cufee/aftermath/internal/localization"
"github.com/cufee/aftermath/internal/log"
"github.com/cufee/aftermath/internal/retry"
Expand Down Expand Up @@ -72,6 +73,9 @@ func (router *router) HTTPHandler() (http.HandlerFunc, error) {
} else {
w.Write([]byte(`{"type":5}`))
}
if f, ok := w.(http.Flusher); ok {
f.Flush()
}

// run the interaction handler
go func() {
Expand Down Expand Up @@ -214,6 +218,19 @@ func (r *router) sendInteractionReply(interaction discordgo.Interaction, data di
return struct{}{}, err
}, 5, time.Second) // better late than never
if res.Err != nil {
if (errors.Is(res.Err, rest.ErrUnknownWebhook) || errors.Is(res.Err, rest.ErrUnknownInteraction)) && interaction.ChannelID != "" {
fallbackCtx, cancel := context.WithTimeout(context.Background(), time.Second*3)
defer cancel()
_, err := r.restClient.CreateMessage(fallbackCtx, interaction.ChannelID, discordgo.MessageSend{
Content: data.Content,
Components: data.Components,
Embeds: data.Embeds,
}, nil)
if err != nil {
log.Err(err).Str("id", interaction.ID).Msg("failed to send a fallback channel message")
}
return
}
log.Err(res.Err).Stack().Any("data", data).Str("id", interaction.ID).Msg("failed to send an interaction response")
return
}
Expand Down
Loading