Conversation
benthongtiang
added
the
minor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Lighthouse Performance ReportMetrics📄Full Report |
…t, function or class Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
johnny-hausman
left a comment
johnny-hausman
left a comment
There was a problem hiding this comment.
What you have done looks good and would seem to work. (I'm assuming it is passing the tests).
However, the goal of the plugins is so that we are exposing all the capabilities of our framework in a way that an EXTERNAL plugin is able to access all the resources it needs to work and display itself in the browser app.
That means when we come across some of the resources like ABViewPropertyFilterData and ABViewProperty LinkPage, we need to make sure they are available in the ABClassManager.getPluginAPI() method that is passing in resources to our plugins.
So instead of linking to them directly in FNAbviewcarousel.js, make sure the ABClassManager.getPluginAPI() is returning those and refer to them that way.
| @@ -0,0 +1,194 @@ | |||
| import FNAbviewcarouselComponent from "./FNAbviewcarouselComponent.js"; | |||
| import ABViewPropertyFilterData from "../../../views/viewProperties/ABViewPropertyFilterData"; | |||
There was a problem hiding this comment.
We need to incorporate this into the Plugin API that is passed into this widget, rather than linking to it directly here.
3 participants
Relate PR
CruGlobal/appbuilder_class_core#334