Docs: Update readme's and doc generation scripts#1722
Conversation
|
🔥 Smoke Test Results✅ Status: Passed Statistics
✅ All smoke tests passed!All critical flows are working correctly. This is a non-blocking smoke test. Full regression tests run separately. |
jmderby
changed the title
Prompt To Fix All With AIThis is a comment left during a code review.
Path: packages/client/ui/scripts/generate-reference.mjs
Line: 26
Comment:
**Stale comment references old API**
The JSDoc comment still references `getOrCreateWallet`, which was renamed to `createWallet` and `getWallet` in this PR. The comment should be updated to reflect the new method names.
```suggestion
* createOnLogin and createWallet share the same WalletCreateArgs<Chain> shape.
```
How can I resolve this? If you propose a fix, please make it concise.Last reviewed commit: "fix lint" |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -25,7 +25,7 @@ import { join, resolve } from "path"; | |||
| * | |||
| * createOnLogin and getOrCreateWallet share the same WalletArgsFor<Chain> shape. | |||
There was a problem hiding this comment.
The JSDoc comment still references getOrCreateWallet, which was renamed to createWallet and getWallet in this PR. The comment should be updated to reflect the new method names.
| * createOnLogin and getOrCreateWallet share the same WalletArgsFor<Chain> shape. | |
| * createOnLogin and createWallet share the same WalletCreateArgs<Chain> shape. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/client/ui/scripts/generate-reference.mjs
Line: 26
Comment:
**Stale comment references old API**
The JSDoc comment still references `getOrCreateWallet`, which was renamed to `createWallet` and `getWallet` in this PR. The comment should be updated to reflect the new method names.
```suggestion
* createOnLogin and createWallet share the same WalletCreateArgs<Chain> shape.
```
How can I resolve this? If you propose a fix, please make it concise.2 participants
Description
Adds readmes' and doc generation updates for respective wallets-v1 changes.
Test plan
idk man too tired to tell
Package updates
@crossmint/wallets-sdk
@crossmint/client-sdk-react-ui
@crossmint/client-sdk-react-native-ui