feat: merge wallets-v1 into main#1721
Merged
albertoelias-crossmint merged 103 commits intomainfrom Mar 21, 2026
Merged
Conversation
…1454) * feat: add onCreateConfig support to separate admin and usage signers - Add OnCreateConfig<C> type to wallets SDK types - Update WalletArgsFor<C> to include optional onCreateConfig field - Modify WalletFactory.createWallet() to use onCreateConfig admin signer when provided - Update validateExistingWalletConfig() to validate onCreateConfig parameters - Add validateSignerCanUseWallet() helper to ensure signer can use wallet - Add getSignerLocator() helper for determining signer locators - Remove server-side restriction from getWallet() method - Add comprehensive tests for onCreateConfig functionality - Update React Base SDK to export OnCreateConfig and support getWallet - Implement getWallet() in CrossmintWalletBaseProvider - Update getOrCreateWallet() to pass through onCreateConfig - Export OnCreateConfig type from React UI SDK This allows delegated signers to use the SDK by separating the concept of admin signer (who creates/owns the wallet) from usage signer (who interacts with it). Co-Authored-By: Guille <guille.a@paella.dev> * fix: export OnCreateConfig and fix getChainType access - Export OnCreateConfig from wallets SDK index - Inline chainType logic in CrossmintWalletBaseProvider instead of accessing private method Co-Authored-By: Guille <guille.a@paella.dev> * refactor: remove args.delegatedSigners field (BREAKING CHANGE) Breaking changes: - Remove delegatedSigners field from WalletArgsFor type - Remove delegatedSigners field from CreateOnLogin type - delegatedSigners now ONLY exist within onCreateConfig When onCreateConfig is provided: - args.signer = the signer that will USE the wallet (can be admin or delegated) - onCreateConfig.adminSigner = the admin who OWNS the wallet (only for creation) - onCreateConfig.delegatedSigners = delegated signers (only for creation) When onCreateConfig is NOT provided (backward compat): - args.signer acts as BOTH the admin and usage signer Updated: - WalletFactory validation logic to handle both cases - React providers to not pass delegatedSigners - Tests to only use onCreateConfig for delegated signers Co-Authored-By: Guille <guille.a@paella.dev> * feat: make onCreateConfig required via WalletCreateArgs type - Created WalletCreateArgs type that extends WalletArgsFor with required onCreateConfig - Updated getOrCreateWallet and createWallet to use WalletCreateArgs - Updated CreateOnLogin type to use WalletCreateArgs - Made onCreateConfig optional in WalletArgsFor for getWallet use cases - args.signer is now always the usage signer, not the admin signer Co-Authored-By: Guille <guille.a@paella.dev> * chore: fix lint issues Co-Authored-By: Guille <guille.a@paella.dev> * chore: update demo apps to use onCreateConfig - Updated smart-wallet/next, quickstart-devkit, and expo apps - All createOnLogin usages now include onCreateConfig with adminSigner - Delegated signers moved from top-level to onCreateConfig Co-Authored-By: Guille <guille.a@paella.dev> * fix: correctly mutate signer in validateExistingWalletConfig - Create tempArgs to capture mutation from mutateSignerFromCustomAuth - Reassign expectedAdminSigner from mutated tempArgs.signer - Ensures external wallet signer reassignment is captured correctly Co-Authored-By: Guille <guille.a@paella.dev> * fix: correctly mutate adminSignerConfig in createWallet - Create tempArgs to capture mutation from mutateSignerFromCustomAuth - Reassign adminSignerConfig from mutated tempArgs.signer - Ensures external wallet signer reassignment works correctly Co-Authored-By: Guille <guille.a@paella.dev> * remove unnecesary type * reuse common functionality from get and create * remove redundant comments * fix tsc issue * fix linter * added client side specific get wallet * fix signers and transactions * fix delegated signer * remove redundant check * fix unit test * make oncreateconfig optional * remove unnecesary format changes * unify getWallet functionality * remove admin from name * fix react provider * remove unnecessary types * remove optional param * refactor: replace 'as any' with custom SmartWalletConfig type - Create SmartWalletConfig type to properly type wallet.config - Replace all 'as any' casts with SmartWalletConfig type - Improve error message clarity by avoiding 'args' in developer-facing text - Addresses PR feedback from Alberto Co-Authored-By: Guille <guille.a@paella.dev> * fix: format error message to meet line length requirements Co-Authored-By: Guille <guille.a@paella.dev> * add passkey logic to delegate signer comparison * fix wallet with multiple passkey signers * remove console.log * appplied albertos comment --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…ers (#1458) * feat: add onCreateConfig support to separate admin and usage signers - Add OnCreateConfig<C> type to wallets SDK types - Update WalletArgsFor<C> to include optional onCreateConfig field - Modify WalletFactory.createWallet() to use onCreateConfig admin signer when provided - Update validateExistingWalletConfig() to validate onCreateConfig parameters - Add validateSignerCanUseWallet() helper to ensure signer can use wallet - Add getSignerLocator() helper for determining signer locators - Remove server-side restriction from getWallet() method - Add comprehensive tests for onCreateConfig functionality - Update React Base SDK to export OnCreateConfig and support getWallet - Implement getWallet() in CrossmintWalletBaseProvider - Update getOrCreateWallet() to pass through onCreateConfig - Export OnCreateConfig type from React UI SDK This allows delegated signers to use the SDK by separating the concept of admin signer (who creates/owns the wallet) from usage signer (who interacts with it). Co-Authored-By: Guille <guille.a@paella.dev> * fix: export OnCreateConfig and fix getChainType access - Export OnCreateConfig from wallets SDK index - Inline chainType logic in CrossmintWalletBaseProvider instead of accessing private method Co-Authored-By: Guille <guille.a@paella.dev> * refactor: remove args.delegatedSigners field (BREAKING CHANGE) Breaking changes: - Remove delegatedSigners field from WalletArgsFor type - Remove delegatedSigners field from CreateOnLogin type - delegatedSigners now ONLY exist within onCreateConfig When onCreateConfig is provided: - args.signer = the signer that will USE the wallet (can be admin or delegated) - onCreateConfig.adminSigner = the admin who OWNS the wallet (only for creation) - onCreateConfig.delegatedSigners = delegated signers (only for creation) When onCreateConfig is NOT provided (backward compat): - args.signer acts as BOTH the admin and usage signer Updated: - WalletFactory validation logic to handle both cases - React providers to not pass delegatedSigners - Tests to only use onCreateConfig for delegated signers Co-Authored-By: Guille <guille.a@paella.dev> * feat: make onCreateConfig required via WalletCreateArgs type - Created WalletCreateArgs type that extends WalletArgsFor with required onCreateConfig - Updated getOrCreateWallet and createWallet to use WalletCreateArgs - Updated CreateOnLogin type to use WalletCreateArgs - Made onCreateConfig optional in WalletArgsFor for getWallet use cases - args.signer is now always the usage signer, not the admin signer Co-Authored-By: Guille <guille.a@paella.dev> * chore: fix lint issues Co-Authored-By: Guille <guille.a@paella.dev> * chore: update demo apps to use onCreateConfig - Updated smart-wallet/next, quickstart-devkit, and expo apps - All createOnLogin usages now include onCreateConfig with adminSigner - Delegated signers moved from top-level to onCreateConfig Co-Authored-By: Guille <guille.a@paella.dev> * fix: correctly mutate signer in validateExistingWalletConfig - Create tempArgs to capture mutation from mutateSignerFromCustomAuth - Reassign expectedAdminSigner from mutated tempArgs.signer - Ensures external wallet signer reassignment is captured correctly Co-Authored-By: Guille <guille.a@paella.dev> * fix: correctly mutate adminSignerConfig in createWallet - Create tempArgs to capture mutation from mutateSignerFromCustomAuth - Reassign adminSignerConfig from mutated tempArgs.signer - Ensures external wallet signer reassignment works correctly Co-Authored-By: Guille <guille.a@paella.dev> * remove unnecesary type * reuse common functionality from get and create * remove redundant comments * fix tsc issue * fix linter * added client side specific get wallet * fix signers and transactions * fix delegated signer * remove redundant check * fix unit test * make oncreateconfig optional * remove unnecesary format changes * unify getWallet functionality * remove admin from name * fix react provider * remove unnecessary types * remove optional param * feat(wallets): add shadow signer support for automatic delegated signers - Add shadowSigner option to WalletOptions type - Create shadow-signer.ts utility for generating device-bound keypairs - Automatically generate shadow signers during wallet creation (client-side only) - Store shadow signer metadata in localStorage - Pass shadow signer configuration through React providers - Support ed25519 for Solana/Stellar and p256 passkeys for EVM chains - Gracefully handle shadow signer creation failures Co-Authored-By: Guille <guille.a@paella.dev> * fix: remove unused @ts-expect-error directive Co-Authored-By: Guille <guille.a@paella.dev> * refactor: replace 'as any' with custom SmartWalletConfig type - Create SmartWalletConfig type to properly type wallet.config - Replace all 'as any' casts with SmartWalletConfig type - Improve error message clarity by avoiding 'args' in developer-facing text - Addresses PR feedback from Alberto Co-Authored-By: Guille <guille.a@paella.dev> * fix: format error message to meet line length requirements Co-Authored-By: Guille <guille.a@paella.dev> * refactor: remove Flow-specific check, let API handle incompatible chains Co-Authored-By: Guille <guille.a@paella.dev> * feat: use shadow signer as active signer for wallet instances - Modified createWallet to set shadow signer as the active signer - Updated getOrCreateWallet to use shadow signer when retrieving existing wallets - Shadow signer now becomes the default signer instead of the one passed by the user Co-Authored-By: Guille <guille.a@paella.dev> * fix: apply biome lint formatting Co-Authored-By: Guille <guille.a@paella.dev> * fix: add localStorage checks for Node.js test environment Co-Authored-By: Guille <guille.a@paella.dev> * wip shadow * remove support for evm * add passkey logic to delegate signer comparison * fix wallet with multiple passkey signers * remove console.log * remove all shadow passkey references * appplied albertos comment * differentiate wallet creation for stellar and solana * fix shadow signer for stellar * move signing shado logic to signer * change shado signer option config * move delegated signer logic to a new function * abstract signature * remove unnecessary change * restructure folder * improve has shadow signer condition * fix import * fix import * fix vitest test in wallets package * refactor: address PR feedback from Alberto - Replace all @ imports with relative imports - Change != null to == null for style consistency - Rename updatedDelegatedSigners to delegatedSigners for clarity - Extract delegated signer registration logic to registerDelegatedSigners method Co-Authored-By: Guille <guille.a@paella.dev> * fix: apply biome formatting Co-Authored-By: Guille <guille.a@paella.dev> * applied comments * added changeset --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* feat: add onCreateConfig support to separate admin and usage signers - Add OnCreateConfig<C> type to wallets SDK types - Update WalletArgsFor<C> to include optional onCreateConfig field - Modify WalletFactory.createWallet() to use onCreateConfig admin signer when provided - Update validateExistingWalletConfig() to validate onCreateConfig parameters - Add validateSignerCanUseWallet() helper to ensure signer can use wallet - Add getSignerLocator() helper for determining signer locators - Remove server-side restriction from getWallet() method - Add comprehensive tests for onCreateConfig functionality - Update React Base SDK to export OnCreateConfig and support getWallet - Implement getWallet() in CrossmintWalletBaseProvider - Update getOrCreateWallet() to pass through onCreateConfig - Export OnCreateConfig type from React UI SDK This allows delegated signers to use the SDK by separating the concept of admin signer (who creates/owns the wallet) from usage signer (who interacts with it). Co-Authored-By: Guille <guille.a@paella.dev> * fix: export OnCreateConfig and fix getChainType access - Export OnCreateConfig from wallets SDK index - Inline chainType logic in CrossmintWalletBaseProvider instead of accessing private method Co-Authored-By: Guille <guille.a@paella.dev> * refactor: remove args.delegatedSigners field (BREAKING CHANGE) Breaking changes: - Remove delegatedSigners field from WalletArgsFor type - Remove delegatedSigners field from CreateOnLogin type - delegatedSigners now ONLY exist within onCreateConfig When onCreateConfig is provided: - args.signer = the signer that will USE the wallet (can be admin or delegated) - onCreateConfig.adminSigner = the admin who OWNS the wallet (only for creation) - onCreateConfig.delegatedSigners = delegated signers (only for creation) When onCreateConfig is NOT provided (backward compat): - args.signer acts as BOTH the admin and usage signer Updated: - WalletFactory validation logic to handle both cases - React providers to not pass delegatedSigners - Tests to only use onCreateConfig for delegated signers Co-Authored-By: Guille <guille.a@paella.dev> * feat: make onCreateConfig required via WalletCreateArgs type - Created WalletCreateArgs type that extends WalletArgsFor with required onCreateConfig - Updated getOrCreateWallet and createWallet to use WalletCreateArgs - Updated CreateOnLogin type to use WalletCreateArgs - Made onCreateConfig optional in WalletArgsFor for getWallet use cases - args.signer is now always the usage signer, not the admin signer Co-Authored-By: Guille <guille.a@paella.dev> * chore: fix lint issues Co-Authored-By: Guille <guille.a@paella.dev> * chore: update demo apps to use onCreateConfig - Updated smart-wallet/next, quickstart-devkit, and expo apps - All createOnLogin usages now include onCreateConfig with adminSigner - Delegated signers moved from top-level to onCreateConfig Co-Authored-By: Guille <guille.a@paella.dev> * fix: correctly mutate signer in validateExistingWalletConfig - Create tempArgs to capture mutation from mutateSignerFromCustomAuth - Reassign expectedAdminSigner from mutated tempArgs.signer - Ensures external wallet signer reassignment is captured correctly Co-Authored-By: Guille <guille.a@paella.dev> * fix: correctly mutate adminSignerConfig in createWallet - Create tempArgs to capture mutation from mutateSignerFromCustomAuth - Reassign adminSignerConfig from mutated tempArgs.signer - Ensures external wallet signer reassignment works correctly Co-Authored-By: Guille <guille.a@paella.dev> * remove unnecesary type * reuse common functionality from get and create * remove redundant comments * fix tsc issue * fix linter * added client side specific get wallet * fix signers and transactions * fix delegated signer * remove redundant check * fix unit test * make oncreateconfig optional * remove unnecesary format changes * unify getWallet functionality * remove admin from name * fix react provider * remove unnecessary types * remove optional param * feat(wallets): add shadow signer support for automatic delegated signers - Add shadowSigner option to WalletOptions type - Create shadow-signer.ts utility for generating device-bound keypairs - Automatically generate shadow signers during wallet creation (client-side only) - Store shadow signer metadata in localStorage - Pass shadow signer configuration through React providers - Support ed25519 for Solana/Stellar and p256 passkeys for EVM chains - Gracefully handle shadow signer creation failures Co-Authored-By: Guille <guille.a@paella.dev> * fix: remove unused @ts-expect-error directive Co-Authored-By: Guille <guille.a@paella.dev> * refactor: replace 'as any' with custom SmartWalletConfig type - Create SmartWalletConfig type to properly type wallet.config - Replace all 'as any' casts with SmartWalletConfig type - Improve error message clarity by avoiding 'args' in developer-facing text - Addresses PR feedback from Alberto Co-Authored-By: Guille <guille.a@paella.dev> * fix: format error message to meet line length requirements Co-Authored-By: Guille <guille.a@paella.dev> * refactor: remove Flow-specific check, let API handle incompatible chains Co-Authored-By: Guille <guille.a@paella.dev> * feat: use shadow signer as active signer for wallet instances - Modified createWallet to set shadow signer as the active signer - Updated getOrCreateWallet to use shadow signer when retrieving existing wallets - Shadow signer now becomes the default signer instead of the one passed by the user Co-Authored-By: Guille <guille.a@paella.dev> * fix: apply biome lint formatting Co-Authored-By: Guille <guille.a@paella.dev> * fix: add localStorage checks for Node.js test environment Co-Authored-By: Guille <guille.a@paella.dev> * wip shadow * remove support for evm * add passkey logic to delegate signer comparison * fix wallet with multiple passkey signers * remove console.log * remove all shadow passkey references * appplied albertos comment * differentiate wallet creation for stellar and solana * fix shadow signer for stellar * implement shadow signers for react native * move signing shado logic to signer * change shado signer option config * move delegated signer logic to a new function * abstract signature * remove unnecessary change * restructure folder * improve has shadow signer condition * fix import * fix import * move shadow signers * fix naming * fix vitest test in wallets package * refactor: address PR feedback from Alberto - Replace all @ imports with relative imports - Change != null to == null for style consistency - Rename updatedDelegatedSigners to delegatedSigners for clarity - Extract delegated signer registration logic to registerDelegatedSigners method Co-Authored-By: Guille <guille.a@paella.dev> * fix: apply biome formatting Co-Authored-By: Guille <guille.a@paella.dev> * move storage to rn package * make shad signer work for react native * applied comments * added changeset * cleanup PR * change back to string * revert chain change * move back to usdc * fix browser storage * add changeset * make browserstorage a string to inject in webview * add all the == null missing * move shadow signer to its own class * fix imports * applied comments * avoid injectin javascript --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* device signer for solana working * change shadow signer config * improve isShadowSignerEnabled logic * fix options * improve signature type * fix tsc issue * added changeset
…let calls (#1559) BREAKING CHANGE: The owner field can no longer be specified in client-side getOrCreateWallet calls. Owner is now determined from JWT authentication. - Add validation in WalletFactory to throw WalletCreationError when owner is provided - Create ClientSideWalletArgsFor and ClientSideWalletCreateArgs types - Update CreateOnLogin type to use client-side types without owner - Remove owner parameter from CrossmintWalletBaseProvider wallet creation Addresses WAL-8180 Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* remove device signers code * fix lint * remove related changesets * restore change
* add device signer config * fix issues on device signer * add changeset * Update packages/wallets/src/wallets/wallet-factory.ts Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> * Update packages/wallets/src/wallets/wallet-factory.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * add device signer to all chains * receive key storage as prop * Update packages/wallets/src/utils/device-signers/DeviceSignerKeyStorage.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * add dependency to use callback * throw error if admin signer is device signer * Update packages/wallets/src/wallets/wallet-factory.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * don't use generic error * apply greptile suggestion * Update packages/wallets/src/wallets/wallet-factory.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix wait for signing email * Apply suggestion from @greptile-apps[bot] Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * change savedevice signer method name * add defensive check --------- Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…er with iframe (#1605) * add device signer config * fix issues on device signer * add changeset * Update packages/wallets/src/wallets/wallet-factory.ts Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> * Update packages/wallets/src/wallets/wallet-factory.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * add device signer to all chains * receive key storage as prop * Update packages/wallets/src/utils/device-signers/DeviceSignerKeyStorage.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * add dependency to use callback * throw error if admin signer is device signer * Update packages/wallets/src/wallets/wallet-factory.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * don't use generic error * apply greptile suggestion * Update packages/wallets/src/wallets/wallet-factory.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix wait for signing email * added iframe key storage * remove unnecessary change * add changeset * add origin validation * Update packages/wallets/src/utils/device-signers/IframeDeviceSignerKeyStorage.ts Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> * unmount iframe when provider is unmounted * fix unit tests --------- Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
* added biometric check * send signature back to iframe * panos comments
* add device signer to new device * add changeset * remove unnecessary code * put ensure in a more general method * apply ais comments * apply comments * remove reactive signer * make biopolicy optional
* fix device signer solana * add changeset * added changset
* feat: add SDK logger decorator to device signer key storage methods Co-Authored-By: Guille <guille.a@paella.dev> * chore: add changeset for device signer logger decorator Co-Authored-By: Guille <guille.a@paella.dev> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…try (#1613) * feat: handle device signer IDB fatal errors with iframe reload and retry - Detect 'indexeddb-fatal' error code from device signer iframe responses - Add reloadIframe() with single-flight pattern to prevent concurrent reloads - Split rpc() into rpc() + sendRpc() for clean retry flow - On fatal IDB error: reload iframe and retry the operation once - Throw descriptive error if fatal persists after reload WAL-9179 Co-Authored-By: Guille <guille.a@paella.dev> * chore: add changeset for wallets package Co-Authored-By: Guille <guille.a@paella.dev> * Apply suggestions from code review Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * refactor: flatten nested if statements in sendRpc handler Co-Authored-By: Guille <guille.a@paella.dev> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
* auth: remove farcaster login Remove all Farcaster authentication code including: - signInWithFarcaster method from CrossmintAuthClient - FarcasterSignIn component - FarcasterProvider component - Farcaster icon - FarcasterMetadata type - 'farcaster' from LoginMethod union type - @farcaster/auth-kit dependencies - Farcaster test cases - Farcaster from demo app loginMethods Co-Authored-By: Alberto Elias <alberto.elias@paella.dev> * chore: update pnpm-lock.yaml after removing @farcaster/auth-kit Co-Authored-By: Alberto Elias <alberto.elias@paella.dev> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: remove incorrect signer mention from getWallet JSDoc Co-Authored-By: Alberto Elias <alberto.elias@paella.dev> * chore: add changeset for getWallet JSDoc fix Co-Authored-By: Alberto Elias <alberto.elias@paella.dev> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* fix: disallow passkey signers in React Native Passkeys (WebAuthn) are not supported in React Native. This adds proper error handling at the provider level to throw clear errors when passkeys are used as recovery signers, delegated signers, or via createPasskeySigner in a React Native context. Co-Authored-By: Alberto Elias <alberto.elias@paella.dev> * refactor: move passkey validation from base provider to React Native provider Instead of adding a disablePasskeys prop to CrossmintWalletBaseProvider, all passkey validation now lives in the React Native CrossmintWalletProvider: - PasskeyGuard component wraps children and overrides the wallet context to reject createWallet with passkey signers and createPasskeySigner calls - hasPasskeySigner check on createOnLogin throws at render time - Base provider remains unchanged Co-Authored-By: Alberto Elias <alberto.elias@paella.dev> * fix: move passkey check into useEffect to respect Rules of Hooks The conditional throw was before hook calls, which violates React's Rules of Hooks if createOnLogin changes dynamically. Moving it into a useEffect ensures all hooks run on every render. Co-Authored-By: Alberto Elias <alberto.elias@paella.dev> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
#1699) * feat: unify OTP signer API with showOtpSignerPrompt and otpSignerState - Replace headlessSigningFlow with showOtpSignerPrompt (defaults true) - Add showOtpSignerPrompt to react-ui CrossmintWalletProvider - Rename emailSignerState to otpSignerState in context - Update useWalletOtpSigner to use otpSignerState - Update demo app and README references Co-Authored-By: Alberto Elias <alberto.elias@paella.dev> * fix: remove explicit showOtpSignerPrompt from README since it defaults to true Co-Authored-By: Alberto Elias <alberto.elias@paella.dev> * fix: showOtpSignerPrompt=false no longer suppresses passkey UI Move OTP dialog gating into the renderUI functions themselves so that passkey prompts are always rendered regardless of showOtpSignerPrompt. renderUI is now always passed to CrossmintWalletBaseProvider. Co-Authored-By: Alberto Elias <alberto.elias@paella.dev> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…-9467) (#1712) * fix: improve error messages when server wallet signer is missing (WAL-9467) Co-Authored-By: Alberto Elias <alberto.elias@paella.dev> * fix: reorder multi-signer check first, remove docs link from server error Co-Authored-By: Alberto Elias <alberto.elias@paella.dev> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* Fixes modal icons and other stuff * changeset * undo conflict * lockfile * fixes --------- Co-authored-by: Alberto Elias <hi@albertoelias.me>
…ey (WAL-9470) (#1717) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* If a signer is in a pending state, approve it and then use it * changeset * fixesl int * handle failed state and fallthrough to create a new signer * use recovery signer to approve delegated signer * stellar fix --------- Co-authored-by: Alberto Elias <hi@albertoelias.me>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Updated pod version * Removed pod injection from plugin * Add podspec to pull podspec from cocoapods trunk * Bundle device signer Podfile fixes into client-sdk-react-native-ui plugin * Update expo demo to use client-sdk-react-native-ui plugin instead of expo-device-signer * Update lockfile after removing expo-device-signer from demo app deps * Add podspec to files allowlist in expo-device-signer package.json * Format package.json to satisfy biome
Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
Contributor
Original prompt from Alberto Elias
|
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
🦋 Changeset detectedLatest commit: 7212419 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Too many files changed for review. ( |
Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
packages/client/react-base/src/providers/CrossmintWalletBaseProvider.tsx
Show resolved
Hide resolved
Contributor
🔥 Smoke Test Results✅ Status: Passed Statistics
✅ All smoke tests passed!All critical flows are working correctly. This is a non-blocking smoke test. Full regression tests run separately. |
* Docs: update readmes and doc gen * fix lint
packages/client/ui/react-ui/src/providers/CrossmintWalletProvider.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
…ry re-renders Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
…ingFlow Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
albertoelias-crossmint
deleted the
devin/1774053734-merge-wallets-v1-into-main
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merges the
wallets-v1feature branch intomain, resolving all 47 merge conflicts. This brings in the new wallet architecture where device signers become the default operational signer and the API shifts from a singlesignerparameter to arecovery+signers[]pattern.Key changes from wallets-v1:
signerremoved fromWalletArgsFor/WalletCreateArgs;recoveryis now required onWalletCreateArgsassembleSigner,onChangeSigner,getOrCreateWalletfrom public APISigner→SignerAdapter,experimental_signer→signer,GetActivityResponse→GetTransfersResponse,DelegatedSignerInput→SignerInputServerSignerLocatoris now a branded type (not plainstring)DeviceInternalSignerConfig,DeviceSignerKeyStorage, auto-registration)toInternalSignerConfigin favor of a simplercreateWalletInstancethat preserves user-provided recovery/signer configsConflict resolution strategy:
packages/wallets/src/): wallets-v1's approach preferred for all naming, types, and implementation patternspnpm installPost-merge fixes:
case "server"merge artifact inassembleSigner(packages/wallets/src/signers/index.ts) — both wallets-v1 and main had this case, resulting in dead code after mergerenderUIinCrossmintWalletProvider(packages/client/ui/react-ui/src/providers/CrossmintWalletProvider.tsx) —createRenderWebUI()was called inline in JSX, creating a new function reference on every render.changeset/pre.json(stale pre-release mode file from wallets-v1)packages/client/ui/react-native/README.md) — replaced staleheadlessSigningFlowreferences with the current prop nameshowOtpSignerPrompt, and corrected default-value documentation to match the code (showOtpSignerPromptdefaults totrue, meaning OTP dialogs are shown by default)🔍 Human review checklist:
wallet-factory.ts— most complex merge (8 conflict regions); verifycreateWallet(recovery + signers pattern) andvalidateSigners/isMatchingPasskeySignerlogic are correctwallets/types.ts— confirmSignerInputreplacesDelegatedSignerInputconsistently, no staleDelegatedSignerreferencesapi/types.ts—GetNftsResponsewas intentionally dropped (unused); verify no runtime references existsigners/types.ts— duplicateServerInternalSignerConfigremoved;InternalSignerConfigunion includesDeviceInternalSignerConfigsigners/index.ts— verify no other duplicatecasebranches remain inassembleSignerswitch after merge artifact cleanup--ours; spot-check a few for correctnessTest plan
pnpm lintpasses cleanly (Biome, 835 files checked)pnpm build:libssucceeds (17 packages built)Package updates
Multiple changesets already included from the wallets-v1 branch (see
.changeset/files). Key version bumps:@crossmint/wallets-sdk: major (breaking API changes)@crossmint/client-sdk-react-base: major (breaking API changes)@crossmint/expo-device-signer: minor (device name support)@crossmint/common-sdk-base: patch (address validation)No additional
pnpm change:addneeded — all changesets were authored on the wallets-v1 branch..changeset/pre.jsonwas removed as it is a stale pre-release mode artifact.Link to Devin session: https://crossmint.devinenterprise.com/sessions/af280747ba884a5ca8ce503d4af29529
Requested by: @albertoelias-crossmint