Host can make offer on listing by stefankarlberg · Pull Request #15 · CraftAcademy/cat-bnb

stefankarlberg · 2019-05-10T13:06:44Z

PT Story

Changes proposed in this pull request:

Feature tests for happy and sad paths for the scenario
Creates a Offer model, columns in db: name, email, location, price with foreign key - listing_id.
Creates Offer controller with 'index', 'new' and 'create' methods
Defines Offer in the routes as a nested route in listings
Creates listing show view, adds form for offer

What we have learned working on this feature:

Learned more about debugging with binding.pry
Refreshes HAML syntax
Nesting routes

Screenshots

…to listing, 1/8 tests going green

…oing red.

…ontroller. Tests still red.

…e of columns in Offer model, adds show method to offers controller

…ew method show in listing-controller

…curate ones, removes empty lines. First test in scenario going green, 1/10

…tep definitions. Happy path all green

…ot filled in.

…essage saying you need to fill in all fields correctly

…relevant step definition, deletes background steps in feature

oliverochman · 2019-05-10T14:33:46Z

+  end
+
+  def new
+    @offer = Offer.new(offer_params)


do you need to use an instance variable here?

oliverochman · 2019-05-10T14:33:58Z

+  end
+
+  def create
+    @listing = Listing.find(params[:listing_id])


do you need to use an instance variable here?

didnt work without

What did you try?

oliverochman · 2019-05-10T14:34:07Z

+
+  def create
+    @listing = Listing.find(params[:listing_id])
+    @offer = @listing.offers.create(offer_params)


do you need to use an instance variable here?

didnt work without

Please explain what is the other option you tried @Carrosen

oliverochman · 2019-05-10T14:52:09Z

+    When I visit the landing page
+
+  Scenario: Host can successfully create an offer
+    Then I should see "Zane"


unnecessary to test for this

oliverochman · 2019-05-10T14:52:20Z

+    Then I should see "Zane"
+    When I click "Make an offer" within "Zane" section
+    Then I should be on the "Zane" listing page
+    Then I should see "Create your offer"


oliverochman · 2019-05-10T14:52:35Z

+    When I click "Make an offer" within "Zane" section
+    Then I should be on the "Zane" listing page
+    Then I should see "Create your offer"
+    And I fill in "Name" with "Steffe"


oliverochman · 2019-05-10T14:52:52Z

+    Then I should be on landing page
+
+  Scenario: Host can not create an offer when not all the fields are filled in.
+    When I click "Make an offer" within "Zane" section


Same comments as above

…ure test

…, all 113 test going green

Carrosen and others added 17 commits May 9, 2019 12:14

creates feature test for host_can_make_offer_on_listing, adds button …

22f9e3b

…to listing, 1/8 tests going green

Creates model Offer. Creates controller Offers.

25be6a9

adds column to db table, Listing references to model offer

1f9a218

Added path to new offer in listings. Trying to make tests pass. Now g…

a408eeb

…oing red.

adds params to controller, tries to fix error, WIP

237efde

Created new partial - form for offer. Adds required params in Offer c…

d7eb10c

…ontroller. Tests still red.

adds validations of db columns to offer spec, and to validate presenc…

2f57db6

…e of columns in Offer model, adds show method to offers controller

Adds new view, listings/show, new path in listings/index on button. N…

33456e4

…ew method show in listing-controller

adds form for offer to show view, changes step definitions to more ac…

6bc6f76

…curate ones, removes empty lines. First test in scenario going green, 1/10

Added new assertion step, 6/10 in Scenario going green.

99b9f4a

changes test in feature to match label on offer form in show view

00218f3

Refrased feature test in host_can_make_offer_on_listing 8/10 go green

2c5b6b3

changes test I should be on landing page to correct syntax to match s…

bd91206

…tep definitions. Happy path all green

Added new Scenario in feature test for sad path, in case fields are n…

98f66ce

…ot filled in.

adds if statement to create method in offers controller, adds error m…

03cab9a

…essage saying you need to fill in all fields correctly

Changed syntax in create method, added listing in Factory bot

0fc9693

deletes unnessecery partial form and folder for offer in view.

052d9fc

oliverochman requested changes May 10, 2019

View reviewed changes

Comment thread features/host_can_make_offer_on_listing.feature Outdated

Comment thread features/host_can_make_offer_on_listing.feature Outdated

Comment thread features/step_definitions/assertion_steps.rb Outdated

Comment thread spec/models/offer_spec.rb

Comment thread app/models/offer.rb

Carrosen added 2 commits May 10, 2019 15:59

adds associations in specs between the offers and listing, deletes ir…

793351c

…relevant step definition, deletes background steps in feature

changes assertion step to expect page to be listing_path

1458b1c

oliverochman requested changes May 10, 2019

View reviewed changes

Carrosen added 2 commits May 10, 2019 17:02

took away instance variable in method for new, changed naming in feat…

24bec19

…ure test

solves merging conflicts, adds user to host_can_make_offer_on_listing…

92fb521

…, all 113 test going green

Conversation

stefankarlberg commented May 10, 2019

Changes proposed in this pull request:

What we have learned working on this feature:

Screenshots

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants