Skip to content

Fix Course Modal Styling#1694

Open
a1-su wants to merge 2 commits intoCourseography:masterfrom
a1-su:fix-course-modal-styling
Open

Fix Course Modal Styling#1694
a1-su wants to merge 2 commits intoCourseography:masterfrom
a1-su:fix-course-modal-styling

Conversation

@a1-su
Copy link
Copy Markdown
Contributor

@a1-su a1-su commented Apr 2, 2026

Proposed Changes

This PR fixes the CSS styling so of the course modal. In particular, it ensures that the modal is now centred in the middle of the screen regardless of the screen width and height, and instead of the opaque black overlay, it is now a lighter gray.

Screenshots of your changes (if applicable) Screenshot 2026-04-02 at 3 31 35 AM

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 2, 2026

Pull Request Test Coverage Report for Build 4d05c0ba-e54d-472c-9270-8a59aa3b26a7

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.384%

Totals Coverage Status
Change from base Build 52b7e702-2341-43fb-a92d-cde445f28de3: 0.0%
Covered Lines: 2316
Relevant Lines: 3945

💛 - Coveralls

@a1-su a1-su requested a review from david-yz-liu April 2, 2026 07:43
style/app.scss Outdated
inset: 0;
position: fixed;
z-index: 2;
display: flex;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good, but please write them in alphabetical order in this set

@a1-su a1-su requested a review from david-yz-liu April 4, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants