Skip to content

--BJS2-97084 - GoalCompletedEvent notification setup with Redis -- User_service#3497

Open
flesheatingcat wants to merge 5 commits intophoenix-master-stream12from
feature/BJS2-97084
Open

--BJS2-97084 - GoalCompletedEvent notification setup with Redis -- User_service#3497
flesheatingcat wants to merge 5 commits intophoenix-master-stream12from
feature/BJS2-97084

Conversation

@flesheatingcat
Copy link
Copy Markdown

@flesheatingcat flesheatingcat commented Nov 10, 2025

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 10, 2025

⚠️ ОШЫБКА: Сборка завалилась: либо ошибки компиляции, либо не прошли тесты, либо возникли ошибки в стиле кода. Пожалуйста, проверь логи и внеси соответствующие изменения в ПР. После этого красная ошибка ниже должна пропасть, но этот комментарий останется - так и должно быть.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 10, 2025

⚠️ ОШЫБКА: Сборка завалилась: либо ошибки компиляции, либо не прошли тесты, либо возникли ошибки в стиле кода. Пожалуйста, проверь логи и внеси соответствующие изменения в ПР. После этого красная ошибка ниже должна пропасть, но этот комментарий останется - так и должно быть.

@flesheatingcat flesheatingcat changed the title --BJS2-97084 - GoalCompletedEvent notification setup with Redis --BJS2-97084 - GoalCompletedEvent notification setup with Redis -- User_service Nov 10, 2025
PavelEzhkov
PavelEzhkov requested changes Nov 23, 2025
View reviewed changes
Comment thread src/main/java/school/faang/user_service/config/RedisConfig.java Outdated
RedisTemplate<String, Object> template = new RedisTemplate<>();
template.setConnectionFactory(jedisConnectionFactory());
template.setKeySerializer(new StringRedisSerializer());
template.setValueSerializer(new StringRedisSerializer());
Copy link
Copy Markdown

@PavelEzhkov PavelEzhkov Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему у всех тут стринга?) почему не хотите работать с json

Comment thread src/main/java/school/faang/user_service/config/RedisConfig.java Outdated
@Bean
public RedisTemplate<String, Object> redisTemplate() {
RedisTemplate<String, Object> template = new RedisTemplate<>();
template.setConnectionFactory(jedisConnectionFactory());
Copy link
Copy Markdown

@PavelEzhkov PavelEzhkov Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

используй бин

Comment thread src/main/java/school/faang/user_service/config/RedisConfig.java Outdated
import org.springframework.data.redis.serializer.StringRedisSerializer;

@Configuration
@RequiredArgsConstructor
Copy link
Copy Markdown

@PavelEzhkov PavelEzhkov Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

аннотация лишняя

Comment thread src/main/java/school/faang/user_service/dto/event/GoalCompletedEvent.java
package school.faang.user_service.dto.event;

public record GoalCompletedEvent(
Long userId,
Copy link
Copy Markdown

@PavelEzhkov PavelEzhkov Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оба значения могут быть null?

Comment thread src/main/java/school/faang/user_service/messaging/GoalCompletedEventPublisher.java Outdated
try {
json = objectMapper.writeValueAsString(goalCompletedEvent);
} catch (JsonProcessingException e) {
throw new DataValidationException("Event to JSON conversion error.");
Copy link
Copy Markdown

@PavelEzhkov PavelEzhkov Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataValidationException не подходит для ошибок сериализации

Comment thread src/main/java/school/faang/user_service/messaging/GoalCompletedEventPublisher.java Outdated
public void publish(GoalCompletedEvent goalCompletedEvent) {
String json;
try {
json = objectMapper.writeValueAsString(goalCompletedEvent);
Copy link
Copy Markdown

@PavelEzhkov PavelEzhkov Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Происходит двойная сериализация сначала в JSON строку, потом RedisTemplate снова сериализует эту строку, можно передать напрямую

Comment thread src/main/java/school/faang/user_service/messaging/GoalCompletedEventPublisher.java

@Component
@RequiredArgsConstructor
public class GoalCompletedEventPublisher {
Copy link
Copy Markdown

@PavelEzhkov PavelEzhkov Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Опять совсем нет логов

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PavelEzhkov PavelEzhkov PavelEzhkov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flesheatingcat @PavelEzhkov