Support Drupal 10; Move away from question description popups#18
Open
xtrasimplicity wants to merge 4 commits intoCornellCustomDev:masterfrom
Open
Support Drupal 10; Move away from question description popups#18xtrasimplicity wants to merge 4 commits intoCornellCustomDev:masterfrom
xtrasimplicity wants to merge 4 commits intoCornellCustomDev:masterfrom
Conversation
This switches away from a popup, in favour of a hidden element, as per the current Cornell University version.
ys2n
added a commit
to uvalib/CD-finder-uva
that referenced
this pull request
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Given Drupal 8 and 9 are now both end of life, I've added support for Drupal 10.
I've also implemented the collapse/expand functionality for question descriptions, rather than showing a pop-up -- as per Cornell's latest version on their website.
Thanks!