fix: NameError at runtime #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prasanna <iprasannamb@gmail.com>
Signed-off-by: Prasanna <iprasannamb@gmail.com>
Author
|
@pradeeban , Also The tests were failing in GitHub Actions with ModuleNotFoundError: No module named 'numpy' because the workflow wasn't installing the main project dependencies. I've updated .github/workflows/tests.yml to install both: requirements.txt , requirements-dev.txt |
Member
|
Thanks for the catch and the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves a runtime crash caused by a missing NumPy import in
concore.pywhenconvert_numpy_to_python()is called.Details
concore.py(Lines 114–124)The function referenced
np.genericwithout importing NumPy, resulting in aNameErrorat runtime.Related Issues
closes #187
Fix
Added the missing import at the top of the file: