Skip to content

fix the check_drive_io output, which had missing values in its entryData#356

Merged
sni merged 1 commit intomainfrom
windows-disk-io-fix-output
Mar 26, 2026
Merged

fix the check_drive_io output, which had missing values in its entryData#356
sni merged 1 commit intomainfrom
windows-disk-io-fix-output

Conversation

@inqrphl
Copy link
Copy Markdown
Contributor

@inqrphl inqrphl commented Mar 26, 2026

add read/write_bytes_rate humanized, used when building the output. it was missing on windows, but present in others

add an empty label, as windows diskIOCounters does not return the label. Have to get it from somehwere else

now the output looks proper in default invocation:

OK - C >2.2 MiB/s <1.8 MiB/s 3.6%, D >0 B/s <170.5 MiB/s 78.8%, E >0 B/s <0 B/s 0.0%, F >0 B/s <0 B/s -0.0%, G >0 B/s <0 B/s -0.0%, H >0 B/s <11.0 B/s 0.0%, I >0 B/s <0 B/s -0.0% |'C_read_count'=5419844c;;;0; 'C_read_bytes'=79799404032c;;;0; 'C_read_time'=4415455.7729ms;;;0; 'C_write_count'=2347106c;;;0; 'C_write_bytes'=53242277888c;;;0; 'C_write_time'=1626288.63ms;;;0; 'C_utilization'=3.6%;95;;0; 'C_queue_depth'=0;;;0; 'D_read_count'=396150c;;;0; 'D_read_bytes'=193035745792c;;;0; 'D_read_time'=231358690.6178ms;;;0; 'D_write_count'=279715c;;;0; 'D_write_bytes'=145494068224c;;;0; 'D_write_time'=2911921.3152ms;;;0; 'D_utilization'=78.8%;95;;0; 'D_queue_depth'=1;;;0; 'E_read_count'=1529c;;;0; 'E_read_bytes'=6730240c;;;0; 'E_read_time'=219.544ms;;;0; 'E_write_count'=434c;;;0; 'E_write_bytes'=2816512c;;;0; 'E_write_time'=131.795ms;;;0; 'E_utilization'=0%;95;;0; 'E_queue_depth'=0;;;0; 'F_read_count'=85954c;;;0; 'F_read_bytes'=49837942272c;;;0; 'F_read_time'=191631.3353ms;;;0; 'F_write_count'=102906c;;;0; 'F_write_bytes'=102907612160c;;;0; 'F_write_time'=1662286.1347ms;;;0; 'F_utilization'=-0%;95;;0; 'F_queue_depth'=0;;;0; 'G_read_count'=1927c;;;0; 'G_read_bytes'=136574976c;;;0; 'G_read_time'=706.3519ms;;;0; 'G_write_count'=75c;;;0; 'G_write_bytes'=323584c;;;0; 'G_write_time'=34.0137ms;;;0; 'G_utilization'=-0%;95;;0; 'G_queue_depth'=0;;;0; 'H_read_count'=7292c;;;0; 'H_read_bytes'=80874496c;;;0; 'H_read_time'=69007.7321ms;;;0; 'H_write_count'=3438c;;;0; 'H_write_bytes'=20377600c;;;0; 'H_write_time'=20552.0979ms;;;0; 'H_utilization'=0%;95;;0; 'H_queue_depth'=0;;;0; 'I_read_count'=907c;;;0; 'I_read_bytes'=2675200c;;;0; 'I_read_time'=1197.4559ms;;;0; 'I_write_count'=197c;;;0; 'I_write_bytes'=1462272c;;;0; 'I_write_time'=72.6853ms;;;0; 'I_utilization'=-0%;95;;0; 'I_queue_depth'=0;;;0;

add read/write_bytes_rate humanized, used when building the output. it was missing on windows, but present in others

add an empty label, as windows diskIOCounters does not return the label. Have to get it from somehwere else
@sni sni merged commit f1a250c into main Mar 26, 2026
139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants