Conversation
ctdaws
commented
Jun 24, 2026
ctdaws
commented
Collaborator
- add validation for experiment data and identification config, which are checked before starting an identification run
- added docstrings to experiment data, including required data shapes and units
- added docstrings to identification config and all required ABCs
- moved main vfm file from vfm.py -> identification.py
- added some runtime checks to spatial parameterisations
… function type matches what the optimiser needs, updated input validation on costparam init
…ome guards to paramterisation values being none when to_map is called
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.