chore(bridge): bump node-pty to ^1.1.0 for Windows prebuilds#3
Open
CommsConnectgmbh wants to merge 1 commit into
Open
chore(bridge): bump node-pty to ^1.1.0 for Windows prebuilds#3CommsConnectgmbh wants to merge 1 commit into
CommsConnectgmbh wants to merge 1 commit into
Conversation
node-pty@1.0.0 has no prebuilt binaries for win32-x64 and fails to compile against modern MSVC (Spectre-mitigation errors, missing PFNCREATEPSEUDOCONSOLE). 1.1.0 ships prebuilds for win32-x64, so Windows installs work without a C++ toolchain. Refs #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-pty@1.0.0does not ship prebuilt binaries forwin32-x64and fails to compile against modern MSVC (Spectre-mitigation errors, missingPFNCREATEPSEUDOCONSOLE).1.1.0ships prebuilds forwin32-x64, so Windows installs work without a C++ toolchain.No API changes between 1.0.0 and 1.1.0 that we use —
pty.spawn(...)signature is unchanged.Refs #1.
Test plan
npm installinbridge/on Windows succeeds without invokingnode-gyp.